From 0fc62a20a56ddab7b5b5b46d0c83bd4f249e1c1e Mon Sep 17 00:00:00 2001
From: Brandon DeRosier <bdero@google.com>
Date: Thu, 15 Feb 2024 12:43:19 -0800
Subject: [PATCH] [Impeller] Add an error message when failing to write golden
 screenshot.

---
 impeller/golden_tests/golden_playground_test_mac.cc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/impeller/golden_tests/golden_playground_test_mac.cc b/impeller/golden_tests/golden_playground_test_mac.cc
index 2ec55586812db..f447f15708fbf 100644
--- a/impeller/golden_tests/golden_playground_test_mac.cc
+++ b/impeller/golden_tests/golden_playground_test_mac.cc
@@ -92,14 +92,19 @@ std::string GetGoldenFilename() {
 
 bool SaveScreenshot(std::unique_ptr<testing::Screenshot> screenshot) {
   if (!screenshot || !screenshot->GetBytes()) {
+    FML_LOG(ERROR) << "Failed to collect screenshot for test " << GetTestName();
     return false;
   }
   std::string test_name = GetTestName();
   std::string filename = GetGoldenFilename();
   testing::GoldenDigest::Instance()->AddImage(
       test_name, filename, screenshot->GetWidth(), screenshot->GetHeight());
-  return screenshot->WriteToPNG(
-      testing::WorkingDirectory::Instance()->GetFilenamePath(filename));
+  if (!screenshot->WriteToPNG(
+          testing::WorkingDirectory::Instance()->GetFilenamePath(filename))) {
+    FML_LOG(ERROR) << "Failed to write screenshot to " << filename;
+    return false;
+  }
+  return true;
 }
 
 bool ShouldTestHaveVulkanValidations() {