From 2392e250e71883e96db1dbedbf38126a9d1a6ec6 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:28:15 -0800 Subject: [PATCH 1/7] [Impeller] updated benchmarks.md new gallery update --- impeller/docs/benchmarks.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 03831eebee378..13610d5762154 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -5,11 +5,13 @@ Here are some noteworthy benchmarks related to Impeller performance: - **New Gallery** - Runs through the Flutter Gallery with a driver test. - Pixel 7 Pro - Skia vs Vulkan Impeller - frame raster time stats: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery__transition_perf%26test%3Dnew_gallery_impeller__transition_perf) + - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X080f13e1d6607d5ad3f4fe5c67e61538) + - Vulkan vs OpenGLES - average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf%26test%3Dnew_gallery_opengles_impeller__transition_perf) - Samsung S10 - - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X8f96868d3a9eeb120bec1f458c577c30) - - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xeb13bfef4ef2947f899646422bbad8c6) - - Vulkan vs OpenGLES - average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xdfca283b38a86fc09129141792cf5a4b) - - Skia vs Vulkan Impeller - 90th percentile frame rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X2cacf305c9d4b1b5fc43f81368803a9b) + - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X777844777514c7b34e736eadbc5dd002) + - Skia vs Vulkan Impeller - 90th percentile frame rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?begin=1707934850&end=1708021250&queries=device_type%3DSM-A025V%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26test%3Dnew_gallery__transition_perf%26test%3Dnew_gallery_impeller__transition_perf) + - (deprecated) OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xeb13bfef4ef2947f899646422bbad8c6) + - (deprecated) Vulkan vs OpenGLES - average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xdfca283b38a86fc09129141792cf5a4b) - Moto G4 (OpenGLES): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xaeae5aa39c9028be43e8a9ad40540bd8) - iPhone 11 - Metal: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X9d52e54d0ac32151cc10feca61ea34cc) From 3883ecbb2da298e19b47808c8236843cc12e36a7 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:36:19 -0800 Subject: [PATCH 2/7] updated animated blur --- impeller/docs/benchmarks.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 13610d5762154..64ebd22829273 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -20,10 +20,10 @@ Here are some noteworthy benchmarks related to Impeller performance: - **Animated Blur Backdrop Filter** - A driver test that scrolls to a screen and animates a Blur Backdrop filter to get progressively blurrier. This covers a gap in the "New Gallery" tests we've seen in places like Wonderous. - - Samsung S10 - - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X71aab43432178775be19fe133cdb5528) - - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X8024e2cd402a6afcefdb18aaabc9533a) - - Vulkan vs OpenGLES - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xb1c6d1bb2e43c633bc3e1aa896cf5b08) + - Pixel 7 Pro + - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X6d3dd43039c95ec80a8b3914cf386f48) + - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X48625544c02c75d050c4440405025d80) + - Vulkan vs OpenGLES - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Danimated_blur_backdrop_filter_perf__timeline_summary%26test%3Danimated_blur_backdrop_filter_perf_opengles__timeline_summary) - Moto G4 (OpenGLES): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X78023772ea9e94c81f37456a7fa7bf46) - iPhone 11 (Metal): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X2f7504aba3db6aeff08cc896081ace55) From a63f56635c85cc7d1c97def2723967a955996f7a Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:40:13 -0800 Subject: [PATCH 3/7] updated advanced blend --- impeller/docs/benchmarks.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 64ebd22829273..082ad67341b76 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -30,8 +30,8 @@ Here are some noteworthy benchmarks related to Impeller performance: - **Animated Advanced Blend** - A driver test like the Animated Blur test, but is displaying a handful of advanced blurs since it represents a specific case exercised in Wonderous. - - Samsung S10 - - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X4ad61cb8047db080bca0808550f0662f) - - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X0095f870c922720957aa4f6db5cefe76) - - Vulkan vs OpenGLES - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X7ee143e5ef1da2f06950c5d281258377) + - Pixel 7 Pro + - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xe742e40d9f7510cf6c8ddbf9eee9d51b) + - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X78baa100c6cadec3171d42063cc857bf) + - Vulkan vs OpenGLES - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Danimated_advanced_blend_perf__timeline_summary%26test%3Danimated_advanced_blend_perf_opengles__timeline_summary) - iPhone 11 (Metal): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X65477f5b5026c0d5ee8fee79122427ab) From f8d742238e4fda8dc300dbc11e6a74a1ee8526a4 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:40:52 -0800 Subject: [PATCH 4/7] removed deprecated entries --- impeller/docs/benchmarks.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 082ad67341b76..2bdaa037c5eec 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -10,8 +10,6 @@ Here are some noteworthy benchmarks related to Impeller performance: - Samsung S10 - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X777844777514c7b34e736eadbc5dd002) - Skia vs Vulkan Impeller - 90th percentile frame rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?begin=1707934850&end=1708021250&queries=device_type%3DSM-A025V%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26test%3Dnew_gallery__transition_perf%26test%3Dnew_gallery_impeller__transition_perf) - - (deprecated) OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xeb13bfef4ef2947f899646422bbad8c6) - - (deprecated) Vulkan vs OpenGLES - average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xdfca283b38a86fc09129141792cf5a4b) - Moto G4 (OpenGLES): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=Xaeae5aa39c9028be43e8a9ad40540bd8) - iPhone 11 - Metal: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X9d52e54d0ac32151cc10feca61ea34cc) From ccefd68cd24c01b337cd62b56f5bcf15ab183059 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:42:45 -0800 Subject: [PATCH 5/7] added vulkan --- impeller/docs/benchmarks.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 2bdaa037c5eec..896ca6d1b258e 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -4,8 +4,9 @@ Here are some noteworthy benchmarks related to Impeller performance: - **New Gallery** - Runs through the Flutter Gallery with a driver test. - Pixel 7 Pro - - Skia vs Vulkan Impeller - frame raster time stats: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery__transition_perf%26test%3Dnew_gallery_impeller__transition_perf) + - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X3f83005df6350b72d23479764c787b2d) - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X080f13e1d6607d5ad3f4fe5c67e61538) + - Skia vs Vulkan Impeller - frame raster time stats: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery__transition_perf%26test%3Dnew_gallery_impeller__transition_perf) - Vulkan vs OpenGLES - average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf%26test%3Dnew_gallery_opengles_impeller__transition_perf) - Samsung S10 - Vulkan: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X777844777514c7b34e736eadbc5dd002) From 781706c4e7dc7c055d759340c7ef4130e6563787 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:53:29 -0800 Subject: [PATCH 6/7] added backdrop blur (since I really care about that one) --- impeller/docs/benchmarks.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 896ca6d1b258e..3406b06c1a560 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -34,3 +34,7 @@ Here are some noteworthy benchmarks related to Impeller performance: - OpenGLES: [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X78baa100c6cadec3171d42063cc857bf) - Vulkan vs OpenGLES - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Danimated_advanced_blend_perf__timeline_summary%26test%3Danimated_advanced_blend_perf_opengles__timeline_summary) - iPhone 11 (Metal): [dashboard](https://flutter-flutter-perf.skia.org/e/?keys=X65477f5b5026c0d5ee8fee79122427ab) + +- **Backdrop Filter Perf** - A driver test that isolates better the performance + of blurs. + - iPhone 11 (Metal): [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&xbaroffset=38815) From ffa9f3557819ef963fb4e2e39576d75fa3168cce Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 15 Feb 2024 10:54:24 -0800 Subject: [PATCH 7/7] updated label --- impeller/docs/benchmarks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/docs/benchmarks.md b/impeller/docs/benchmarks.md index 3406b06c1a560..f2a5b5f700678 100644 --- a/impeller/docs/benchmarks.md +++ b/impeller/docs/benchmarks.md @@ -37,4 +37,4 @@ Here are some noteworthy benchmarks related to Impeller performance: - **Backdrop Filter Perf** - A driver test that isolates better the performance of blurs. - - iPhone 11 (Metal): [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&xbaroffset=38815) + - iPhone 11 (Metal) - Average rasterizer time: [dashboard](https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3Daverage_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&xbaroffset=38815)