Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Feb 8, 2024

This change starts executing the suites with extra arguments, namely txt_tests, though the implementation does not limit to the suite.

Bug: flutter/flutter#140179

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zijiehe-google-com zijiehe-google-com marked this pull request as ready for review February 9, 2024 18:22
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@zijiehe-google-com zijiehe-google-com added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@zijiehe-google-com
Copy link
Contributor Author

Thank you, the new test suite run_tests_test.py is added and running correctly.
Go ahead to merge this change with autosubmit.

@auto-submit auto-submit bot merged commit 2882076 into flutter:main Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 13, 2024
…143393)

flutter/engine@8742f1c...0091a49

2024-02-13 [email protected] [Impeller] remove denylist entry. (flutter/engine#50605)
2024-02-13 [email protected] [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604)
2024-02-13 [email protected] Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416)
2024-02-13 [email protected] Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603)
2024-02-13 [email protected] [Impeller] replaced playground macros with functions (flutter/engine#50602)
2024-02-13 [email protected] Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575)
2024-02-13 6844906[email protected] [Fuchsia] Run tests with test arguments (flutter/engine#50478)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants