From bf62aa040b71fc45d80e2ac0aea6d8da01fb3703 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Fri, 19 Jan 2024 16:37:31 -0800 Subject: [PATCH] [Impeller] fixed CanRenderClippedRuntimeEffects for vulkan --- impeller/aiks/aiks_unittests.cc | 3 ++- impeller/golden_tests/golden_playground_test_mac.cc | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/impeller/aiks/aiks_unittests.cc b/impeller/aiks/aiks_unittests.cc index 6df57455ee292..803a02cc4a9d0 100644 --- a/impeller/aiks/aiks_unittests.cc +++ b/impeller/aiks/aiks_unittests.cc @@ -2742,7 +2742,8 @@ TEST_P(AiksTest, CanRenderClippedRuntimeEffects) { TEST_P(AiksTest, DrawPaintTransformsBounds) { auto runtime_stages = OpenAssetAsRuntimeStage("gradient.frag.iplr"); - auto runtime_stage = runtime_stages[RuntimeStageBackend::kMetal]; + auto runtime_stage = + runtime_stages[PlaygroundBackendToRuntimeStageBackend(GetBackend())]; ASSERT_TRUE(runtime_stage); ASSERT_TRUE(runtime_stage->IsDirty()); diff --git a/impeller/golden_tests/golden_playground_test_mac.cc b/impeller/golden_tests/golden_playground_test_mac.cc index bbd544a56609e..996e144a98caa 100644 --- a/impeller/golden_tests/golden_playground_test_mac.cc +++ b/impeller/golden_tests/golden_playground_test_mac.cc @@ -58,9 +58,6 @@ static const std::vector kSkipTests = { "impeller_Play_AiksTest_CanRenderClippedRuntimeEffects_Vulkan", "impeller_Play_AiksTest_CaptureContext_Metal", "impeller_Play_AiksTest_CaptureContext_Vulkan", - // TODO(https://github.com/flutter/flutter/issues/141891): This tests - // crashes on vulkan and needs to be fixed. - "impeller_Play_AiksTest_DrawPaintTransformsBounds_Vulkan", }; namespace {