From 4237cc3868dc5fc98269c0da1ee6846e287da3e0 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Thu, 21 Dec 2023 12:47:02 -0800 Subject: [PATCH] [Impeller] Do not skip rendering when mask blur is zero --- impeller/aiks/aiks_unittests.cc | 2 +- impeller/aiks/canvas.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/impeller/aiks/aiks_unittests.cc b/impeller/aiks/aiks_unittests.cc index 0a62a13f9ad10..3fe4f77b4ecbd 100644 --- a/impeller/aiks/aiks_unittests.cc +++ b/impeller/aiks/aiks_unittests.cc @@ -3768,7 +3768,7 @@ TEST_P(AiksTest, MaskBlurWithZeroSigmaIsSkipped) { Canvas canvas; Paint paint = { - .color = Color::White(), + .color = Color::Blue(), .mask_blur_descriptor = Paint::MaskBlurDescriptor{ .style = FilterContents::BlurStyle::kNormal, diff --git a/impeller/aiks/canvas.cc b/impeller/aiks/canvas.cc index 28c1ef2103560..c5b9ae9e598b7 100644 --- a/impeller/aiks/canvas.cc +++ b/impeller/aiks/canvas.cc @@ -281,7 +281,7 @@ bool Canvas::AttemptDrawBlurredRRect(const Rect& rect, } // A blur sigma that is close to zero should not result in any shadow. if (std::fabs(paint.mask_blur_descriptor->sigma.sigma) <= kEhCloseEnough) { - return true; + return false; } Paint new_paint = paint;