From fdb90324b9bcff258943988aa7816441d6fcf12b Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Thu, 1 Jun 2023 14:34:10 -0700 Subject: [PATCH 1/2] Do not retry lint or clang tidy tests. Retries on lints and clang tidy were hiding the issues as timeouts rather than providing the fail signal right away. Bug: https://github.com/flutter/flutter/issues/128083 --- ci/builders/linux_clang_tidy.json | 2 ++ ci/builders/mac_clang_tidy.json | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json index 89893d7f4741a..2bc3ce148a968 100644 --- a/ci/builders/linux_clang_tidy.json +++ b/ci/builders/linux_clang_tidy.json @@ -61,6 +61,7 @@ "--shard-id=1", "--shard-variants=android_debug_arm64" ], + "max_attempts": 1, "script": "flutter/ci/lint.sh" } ] @@ -86,6 +87,7 @@ "--shard-id=0", "--shard-variants=host_debug" ], + "max_attempts": 1, "script": "flutter/ci/lint.sh" } ] diff --git a/ci/builders/mac_clang_tidy.json b/ci/builders/mac_clang_tidy.json index 9a710376ac8bd..e0f0b73a34ccf 100644 --- a/ci/builders/mac_clang_tidy.json +++ b/ci/builders/mac_clang_tidy.json @@ -70,6 +70,7 @@ "--shard-id=1", "--shard-variants=ios_debug_sim" ], + "max_attempts": 1, "script": "flutter/ci/lint.sh" } ] @@ -99,6 +100,7 @@ "--shard-id=0", "--shard-variants=host_debug" ], + "max_attempts": 1, "script": "flutter/ci/lint.sh" } ] From 6941f2006f4ea1f2ad3e5a4c29e7496a99bf7cef Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Thu, 1 Jun 2023 14:41:09 -0700 Subject: [PATCH 2/2] Also run license checker once. --- ci/builders/standalone/linux_license.json | 1 + 1 file changed, 1 insertion(+) diff --git a/ci/builders/standalone/linux_license.json b/ci/builders/standalone/linux_license.json index 95504a1ac2032..15a792c79b89b 100644 --- a/ci/builders/standalone/linux_license.json +++ b/ci/builders/standalone/linux_license.json @@ -11,6 +11,7 @@ "tests": [ { "name": "licenses check", + "max_attempts": 1, "script": "flutter/ci/licenses.sh" } ]