Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix tidy issues #42457

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix tidy issues #42457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1698514
Fix tidy issues
dnfield May 31, 2023
c2b220d
Apply suggestions from code review
dnfield May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ui/painting/image_decoder_impeller.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ ImageDecoderImpeller::UploadTextureToPrivate(
const std::shared_ptr<impeller::Context>& context,
const std::shared_ptr<impeller::DeviceBuffer>& buffer,
const SkImageInfo& image_info,
// NOLINTNEXTLINE(performance-unnecessary-value-param)
std::shared_ptr<SkBitmap> bitmap,
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch) {
TRACE_EVENT0("impeller", __FUNCTION__);
Expand Down Expand Up @@ -365,6 +366,7 @@ ImageDecoderImpeller::UploadTextureToPrivate(
std::pair<sk_sp<DlImage>, std::string>
ImageDecoderImpeller::UploadTextureToShared(
const std::shared_ptr<impeller::Context>& context,
// NOLINTNEXTLINE(performance-unnecessary-value-param)
std::shared_ptr<SkBitmap> bitmap,
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch,
bool create_mips) {
Expand Down
2 changes: 2 additions & 0 deletions lib/ui/painting/image_decoder_impeller.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class ImageDecoderImpeller final : public ImageDecoder {
const std::shared_ptr<impeller::Context>& context,
const std::shared_ptr<impeller::DeviceBuffer>& buffer,
const SkImageInfo& image_info,
// NOLINTNEXTLINE(performance-unnecessary-value-param)
std::shared_ptr<SkBitmap> bitmap,
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch);

Expand All @@ -93,6 +94,7 @@ class ImageDecoderImpeller final : public ImageDecoder {
/// @return A DlImage.
static std::pair<sk_sp<DlImage>, std::string> UploadTextureToShared(
const std::shared_ptr<impeller::Context>& context,
// NOLINTNEXTLINE(performance-unnecessary-value-param)
std::shared_ptr<SkBitmap> bitmap,
const std::shared_ptr<fml::SyncSwitch>& gpu_disabled_switch,
bool create_mips = true);
Expand Down