From 42984d40b48acf667308e4a486c8904066f5ceca Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Fri, 12 May 2023 13:10:52 -0700 Subject: [PATCH 1/4] Add linux_clang_tidy builder. This builder run android and host clang tidy in an engine v2 build. --- .ci.yaml | 8 +++ ci/builders/linux_clang_tidy.json | 98 +++++++++++++++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 ci/builders/linux_clang_tidy.json diff --git a/.ci.yaml b/.ci.yaml index 116fa5e5b7f87..a987f85ef273e 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -263,6 +263,14 @@ targets: release_build: "true" config_name: linux_fuchsia + - name: Linux linux_clang_tidy + bringup: true + recipe: engine_v2/engine_v2 + timeout: 60 + properties: + release_build: "true" + config_name: linux_clang_tidy + - name: Linux linux_arm_host_engine recipe: engine_v2/engine_v2 timeout: 60 diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json new file mode 100644 index 0000000000000..2656dbe76da1e --- /dev/null +++ b/ci/builders/linux_clang_tidy.json @@ -0,0 +1,98 @@ +{ + "builds": [ + { + "archives": [], + "drone_dimensions": [ + "device_type=none", + "os=Linux" + ], + "gn": [ + "--android", + "--android-cpu", + "arm64", + "--no-lto" + ], + "name": "android_debug_arm64", + "ninja": { + "config": "android_debug_arm64" + } + }, + { + "archives": [], + "drone_dimensions": [ + "device_type=none", + "os=Linux" + ], + "gn": [ + "--runtime-mode", + "debug", + "--prebuilt-dart-sdk", + "--no-lto" + ], + "name": "host_debug", + "ninja": { + "config": "host_debug" + } + } + ], + "tests": [ + { + "name": "test: lint host_debug", + "recipe": "engine_v2/tester_engine", + "drone_dimensions": [ + "device_type=none", + "os=Mac", + "cpu=arm64" + ], + "gclient_variables": { + "download_android_deps": false + }, + "dependencies": [ + "host_debug", + "ios_debug_sim" + ], + "tasks": [ + { + "name": "test: lint host_debug", + "parameters": [ + "--variant", + "host_debug", + "--lint-all", + "--shard-id=1", + "--shard-variants=android_debug_arm64" + ], + "script": "flutter/ci/lint.sh" + } + ] + }, + { + "name": "test: lint ios_debug_sim", + "recipe": "engine_v2/tester_engine", + "drone_dimensions": [ + "device_type=none", + "os=Mac", + "cpu=arm64" + ], + "gclient_variables": { + "download_android_deps": false + }, + "dependencies": [ + "host_debug", + "ios_debug_sim" + ], + "tasks": [ + { + "name": "test: lint android_debug_arm64", + "parameters": [ + "--variant", + "android_debug_arm64", + "--lint-all", + "--shard-id=0", + "--shard-variants=host_debug" + ], + "script": "flutter/ci/lint.sh" + } + ] + } + ] +} From c60b31ce7ce044d3f5f79e66e4de44c51cd12083 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Fri, 12 May 2023 14:24:18 -0700 Subject: [PATCH 2/4] Fix dep names. --- ci/builders/linux_clang_tidy.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json index 2656dbe76da1e..d143c0c490826 100644 --- a/ci/builders/linux_clang_tidy.json +++ b/ci/builders/linux_clang_tidy.json @@ -49,7 +49,7 @@ }, "dependencies": [ "host_debug", - "ios_debug_sim" + "android_debug_arm64" ], "tasks": [ { From 47ad19077c808564a52521340a0a949a5b4414d6 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Fri, 12 May 2023 15:01:15 -0700 Subject: [PATCH 3/4] Add second test. --- ci/builders/linux_clang_tidy.json | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json index d143c0c490826..d99c7451464a6 100644 --- a/ci/builders/linux_clang_tidy.json +++ b/ci/builders/linux_clang_tidy.json @@ -41,8 +41,7 @@ "recipe": "engine_v2/tester_engine", "drone_dimensions": [ "device_type=none", - "os=Mac", - "cpu=arm64" + "os=Linux" ], "gclient_variables": { "download_android_deps": false @@ -66,19 +65,18 @@ ] }, { - "name": "test: lint ios_debug_sim", + "name": "test: lint android_debug_arm64", "recipe": "engine_v2/tester_engine", "drone_dimensions": [ "device_type=none", - "os=Mac", - "cpu=arm64" + "os=Linux" ], "gclient_variables": { "download_android_deps": false }, "dependencies": [ "host_debug", - "ios_debug_sim" + "android_debug_arm64" ], "tasks": [ { From feff9ec1f487589c5beb10525f0a4cf1a4bd7573 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Fri, 12 May 2023 19:29:43 -0700 Subject: [PATCH 4/4] Use 32 cores for host engine lints. --- ci/builders/linux_clang_tidy.json | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json index d99c7451464a6..89893d7f4741a 100644 --- a/ci/builders/linux_clang_tidy.json +++ b/ci/builders/linux_clang_tidy.json @@ -41,7 +41,8 @@ "recipe": "engine_v2/tester_engine", "drone_dimensions": [ "device_type=none", - "os=Linux" + "os=Linux", + "cores=32" ], "gclient_variables": { "download_android_deps": false @@ -71,9 +72,6 @@ "device_type=none", "os=Linux" ], - "gclient_variables": { - "download_android_deps": false - }, "dependencies": [ "host_debug", "android_debug_arm64"