Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jezell
Copy link

@jezell jezell commented Apr 27, 2023

Implements flutter/flutter#123277

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 27, 2023
@google-cla
Copy link

google-cla bot commented Apr 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Hixie
Copy link
Contributor

Hixie commented Jun 27, 2023

@jezell Thanks for your contribution. Unfortunately without the CLA being signed we cannot consider your code. I'm going to close this PR as per the bot's comment above, but please don't hesitate to resubmit a PR if you are ever in a position to sign the CLA. Thanks!

@Hixie Hixie closed this Jun 27, 2023
@jezell
Copy link
Author

jezell commented Jun 29, 2023

@Hixie I did sign the CLA...

@Hixie
Copy link
Contributor

Hixie commented Jul 5, 2023

Ah, I see. It looks like your commits had multiple e-mail addresses and that confused the bot, which marked it as unsigned, which caused everyone on the team to ignore the PR. Can you resend the patch with all your commits coming from the e-mail you have signed with, as a new PR? Then we can get this routed for actual code review. Sorry for all the hoop jumping, the lawyers insist on this process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants