From 4700c53d989cf34b78aa1ca7567c66573df6ed79 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Thu, 9 Mar 2023 20:38:09 -0800 Subject: [PATCH] fix typo in LayerInfo::has_compatible_op --- display_list/display_list_builder.h | 2 +- display_list/display_list_unittests.cc | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/display_list/display_list_builder.h b/display_list/display_list_builder.h index 4226d6a3cfcfe..58e20f1e0212f 100644 --- a/display_list/display_list_builder.h +++ b/display_list/display_list_builder.h @@ -446,7 +446,7 @@ class DisplayListBuilder final : public virtual DlCanvas, bool has_layer() const { return has_layer_; } bool cannot_inherit_opacity() const { return cannot_inherit_opacity_; } - bool has_compatible_op() const { return cannot_inherit_opacity_; } + bool has_compatible_op() const { return has_compatible_op_; } bool is_group_opacity_compatible() const { return !cannot_inherit_opacity_; diff --git a/display_list/display_list_unittests.cc b/display_list/display_list_unittests.cc index c7b2311301821..9b942bb442ead 100644 --- a/display_list/display_list_unittests.cc +++ b/display_list/display_list_unittests.cc @@ -2403,5 +2403,17 @@ TEST(DisplayList, RTreeRenderCulling) { } } +TEST(DisplayListTest, DrawSaveDrawCannotInheritOpacity) { + DisplayListBuilder builder; + builder.DrawCircle({10, 10}, 5, DlPaint()); + builder.Save(); + builder.ClipRect({0, 0, 20, 20}, DlCanvas::ClipOp::kIntersect, false); + builder.DrawRect({5, 5, 15, 15}, DlPaint()); + builder.Restore(); + auto display_list = builder.Build(); + + ASSERT_FALSE(display_list->can_apply_group_opacity()); +} + } // namespace testing } // namespace flutter