From 6082b396caa5987493e3753b6a7af077134f847b Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Tue, 2 Aug 2022 14:17:56 -0700 Subject: [PATCH] fix typos buider -> builder --- .../display_list_builder_benchmarks.cc | 62 +++++++++---------- .../fuchsia/flutter/platform_view_unittest.cc | 2 +- .../tests/flatland_platform_view_unittest.cc | 2 +- 3 files changed, 33 insertions(+), 33 deletions(-) diff --git a/display_list/display_list_builder_benchmarks.cc b/display_list/display_list_builder_benchmarks.cc index 4ebadb4521bc6..ed1d093de31e0 100644 --- a/display_list/display_list_builder_benchmarks.cc +++ b/display_list/display_list_builder_benchmarks.cc @@ -48,8 +48,8 @@ static void Complete(DisplayListBuilder& builder, } // namespace -static void BM_DisplayListBuiderDefault(benchmark::State& state, - DisplayListBuilderBenchmarkType type) { +static void BM_DisplayListBuilderDefault(benchmark::State& state, + DisplayListBuilderBenchmarkType type) { while (state.KeepRunning()) { DisplayListBuilder builder; InvokeAllRenderingOps(builder); @@ -57,7 +57,7 @@ static void BM_DisplayListBuiderDefault(benchmark::State& state, } } -static void BM_DisplayListBuiderWithScaleAndTranslate( +static void BM_DisplayListBuilderWithScaleAndTranslate( benchmark::State& state, DisplayListBuilderBenchmarkType type) { while (state.KeepRunning()) { @@ -69,7 +69,7 @@ static void BM_DisplayListBuiderWithScaleAndTranslate( } } -static void BM_DisplayListBuiderWithPerspective( +static void BM_DisplayListBuilderWithPerspective( benchmark::State& state, DisplayListBuilderBenchmarkType type) { while (state.KeepRunning()) { @@ -81,7 +81,7 @@ static void BM_DisplayListBuiderWithPerspective( } } -static void BM_DisplayListBuiderWithClipRect( +static void BM_DisplayListBuilderWithClipRect( benchmark::State& state, DisplayListBuilderBenchmarkType type) { SkRect clip_bounds = SkRect::MakeLTRB(6.5, 7.3, 90.2, 85.7); @@ -93,7 +93,7 @@ static void BM_DisplayListBuiderWithClipRect( } } -static void BM_DisplayListBuiderWithSaveLayer( +static void BM_DisplayListBuilderWithSaveLayer( benchmark::State& state, DisplayListBuilderBenchmarkType type) { while (state.KeepRunning()) { @@ -110,7 +110,7 @@ static void BM_DisplayListBuiderWithSaveLayer( } } -static void BM_DisplayListBuiderWithSaveLayerAndImageFilter( +static void BM_DisplayListBuilderWithSaveLayerAndImageFilter( benchmark::State& state, DisplayListBuilderBenchmarkType type) { DlPaint layer_paint; @@ -130,104 +130,104 @@ static void BM_DisplayListBuiderWithSaveLayerAndImageFilter( } } -BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault, +BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault, +BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault, +BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderDefault, +BENCHMARK_CAPTURE(BM_DisplayListBuilderDefault, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithScaleAndTranslate, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithScaleAndTranslate, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithPerspective, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithPerspective, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithClipRect, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithClipRect, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayer, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayer, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter, kDefault, DisplayListBuilderBenchmarkType::kDefault) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter, kBounds, DisplayListBuilderBenchmarkType::kBounds) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter, kRtree, DisplayListBuilderBenchmarkType::kRtree) ->Unit(benchmark::kMillisecond); -BENCHMARK_CAPTURE(BM_DisplayListBuiderWithSaveLayerAndImageFilter, +BENCHMARK_CAPTURE(BM_DisplayListBuilderWithSaveLayerAndImageFilter, kBoundsAndRtree, DisplayListBuilderBenchmarkType::kBoundsAndRtree) ->Unit(benchmark::kMillisecond); diff --git a/shell/platform/fuchsia/flutter/platform_view_unittest.cc b/shell/platform/fuchsia/flutter/platform_view_unittest.cc index 3afa8526877f3..a02ebb21f4deb 100644 --- a/shell/platform/fuchsia/flutter/platform_view_unittest.cc +++ b/shell/platform/fuchsia/flutter/platform_view_unittest.cc @@ -316,7 +316,7 @@ class PlatformViewBuilder { // Once Build is called, the instance is no longer usable. GfxPlatformView Build() { EXPECT_FALSE(std::exchange(built_, true)) - << "Build() was already called, this buider is good for one use only."; + << "Build() was already called, this builder is good for one use only."; return GfxPlatformView( delegate_, task_runners_, std::move(view_ref_pair_.view_ref), external_external_view_embedder_, std::move(ime_service_), diff --git a/shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc b/shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc index 0e804e1f68890..674030b0fc959 100644 --- a/shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc +++ b/shell/platform/fuchsia/flutter/tests/flatland_platform_view_unittest.cc @@ -421,7 +421,7 @@ class PlatformViewBuilder { // Once Build is called, the instance is no longer usable. FlatlandPlatformView Build() { EXPECT_FALSE(std::exchange(built_, true)) - << "Build() was already called, this buider is good for one use only."; + << "Build() was already called, this builder is good for one use only."; return FlatlandPlatformView( delegate_, task_runners_, std::move(view_ref_pair_.view_ref), external_external_view_embedder_, std::move(ime_service_),