From 7da973b2bb9c4eac7850dd8a3875e39399423ce5 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 14 Jul 2022 14:06:25 -0700 Subject: [PATCH 1/2] Skip test that crashes platform --- .../scenariosui/PlatformViewWithSurfaceViewUiTest.java | 6 +++++- testing/scenario_app/lib/src/platform_view.dart | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java b/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java index b1fcf35d7d55d..33e5995e3d41a 100644 --- a/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java +++ b/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java @@ -12,6 +12,7 @@ import androidx.test.runner.AndroidJUnit4; import dev.flutter.scenarios.PlatformViewsActivity; import org.junit.Before; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; @@ -124,9 +125,12 @@ public void testPlatformViewWithoutOverlayIntersection() throws Exception { goldName("testPlatformViewWithoutOverlayIntersection")); } + // TODO(dnfield): This is not safe until https://github.com/flutter/flutter/issues/31990 + // is resolved. + @Ignore @Test public void testPlatformViewLargerThanDisplaySize() throws Exception { - // Regression test for https://github.com/flutter/flutter/issues/2897. + // Regression test for https://github.com/flutter/flutter/issues/28978. intent.putExtra("scenario_name", "platform_view_larger_than_display_size"); ScreenshotUtil.capture( activityRule.launchActivity(intent), goldName("testPlatformViewLargerThanDisplaySize")); diff --git a/testing/scenario_app/lib/src/platform_view.dart b/testing/scenario_app/lib/src/platform_view.dart index 8f1704e6ef6a2..cd3e99d65c9ed 100644 --- a/testing/scenario_app/lib/src/platform_view.dart +++ b/testing/scenario_app/lib/src/platform_view.dart @@ -117,7 +117,7 @@ class PlatformViewNoOverlayIntersectionScenario extends Scenario /// A platform view that is larger than the display size. /// This is only applicable on Android while using virtual displays. -/// Related issue: https://github.com/flutter/flutter/issues/2897. +/// Related issue: https://github.com/flutter/flutter/issues/28978. class PlatformViewLargerThanDisplaySize extends Scenario with _BasePlatformViewScenarioMixin { /// Creates the PlatformView scenario. From ff9d972c0d65d698a662c042dee5001b45061870 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 14 Jul 2022 14:42:28 -0700 Subject: [PATCH 2/2] Skip test that crashes platform --- .../flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java b/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java index 33e5995e3d41a..b445a3d8407a5 100644 --- a/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java +++ b/testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java @@ -127,7 +127,7 @@ public void testPlatformViewWithoutOverlayIntersection() throws Exception { // TODO(dnfield): This is not safe until https://github.com/flutter/flutter/issues/31990 // is resolved. - @Ignore + @Ignore("not safe until https://github.com/flutter/flutter/issues/31990 is resolved") @Test public void testPlatformViewLargerThanDisplaySize() throws Exception { // Regression test for https://github.com/flutter/flutter/issues/28978.