This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "iOS Background Platform Channels" #30289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 485b37c.
zanderso
approved these changes
Dec 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2021
This was referenced Dec 16, 2021
Member
|
The attached internal issue mentions a hang, not definitively called a deadlock, identifies this PR as a likely cause and doesn't provide a stack trace. That makes this difficult to debug. The only new lock that they could have encountered would be the That is used when setting the message handler and when handling messages. With this tiny amount of information I suspect they are getting self deadlock by setting message handlers when message handlers are called. |
Member
|
It's not self deadlock since the mutex is not held whilst calling handlers. I couldn't reproduce a deadlock that way. |
This was referenced Jan 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29665
Caused internal breakage documented in b/209838044
@gaaclarke fyi