Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@xster
Copy link
Member

@xster xster commented Nov 18, 2021

Request: b/206892337

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla google-cla bot added the cla: yes label Nov 18, 2021
@xster xster requested a review from zanderso November 18, 2021 19:01
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman
Copy link
Member

jmagman commented Nov 19, 2021

The luci link is missing but the Mac Unopt failure is https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/6226.
Rebase onto #29668

@jmagman
Copy link
Member

jmagman commented Nov 19, 2021

Rebase onto #29668

Oh never mind, this is a cherry-pick.

@xster
Copy link
Member Author

xster commented Nov 20, 2021

I'm not cherry picking that bigger change into this cherry pick. It's a lint that failed and Mac iOS Engine has reasonable coverage. I'm merging this

@xster xster merged commit e04bc2b into flutter:flutter-2.8-candidate.6 Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants