From c0a1dbd8c1bd91bfbd33b8fe1444800ed0c13ebb Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 28 Sep 2021 11:57:47 -0700 Subject: [PATCH 1/4] Added note and deprecation annotation for splash screen provider --- .../io/flutter/embedding/android/SplashScreenProvider.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java index f30467875c806..da0c77b22b6eb 100644 --- a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java +++ b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java @@ -8,7 +8,14 @@ /** * Provides a {@link SplashScreen} to display while Flutter initializes and renders its first frame. + * + *

Please use the new Splash screen API available on Android S. On lower versions of Android, + * it's no longer necessary to display a splash screen to wait for the Flutter first frame, and thus, + * there is no longer a need to provide an implementation of this interface. + * + * @deprecated */ +@Deprecated public interface SplashScreenProvider { /** * Provides a {@link SplashScreen} to display while Flutter initializes and renders its first From 800b2327afe891aec77a01e75e60b39a1295dade Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 28 Sep 2021 13:48:07 -0700 Subject: [PATCH 2/4] fixed formatting --- .../io/flutter/embedding/android/SplashScreenProvider.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java index da0c77b22b6eb..3cfa1cfafccdc 100644 --- a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java +++ b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java @@ -10,8 +10,8 @@ * Provides a {@link SplashScreen} to display while Flutter initializes and renders its first frame. * *

Please use the new Splash screen API available on Android S. On lower versions of Android, - * it's no longer necessary to display a splash screen to wait for the Flutter first frame, and thus, - * there is no longer a need to provide an implementation of this interface. + * it's no longer necessary to display a splash screen to wait for the Flutter first frame, and + * thus, there is no longer a need to provide an implementation of this interface. * * @deprecated */ From f22558176d78a8329f76bf0a997368020ebbc2e7 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 28 Sep 2021 14:56:57 -0700 Subject: [PATCH 3/4] Modified comment --- .../io/flutter/embedding/android/SplashScreenProvider.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java index 3cfa1cfafccdc..bf7255eae3948 100644 --- a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java +++ b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java @@ -9,8 +9,7 @@ /** * Provides a {@link SplashScreen} to display while Flutter initializes and renders its first frame. * - *

Please use the new Splash screen API available on Android S. On lower versions of Android, - * it's no longer necessary to display a splash screen to wait for the Flutter first frame, and + *

Flutter now automatically keeps the Android launch screen displayed until Flutter has drawn the first frame, and * thus, there is no longer a need to provide an implementation of this interface. * * @deprecated From 9be86abccdbc3f848afb40b8f89d3f52dc23b199 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 28 Sep 2021 14:57:32 -0700 Subject: [PATCH 4/4] Fixed formatting of comment --- .../io/flutter/embedding/android/SplashScreenProvider.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java index bf7255eae3948..f048c9f8c9eae 100644 --- a/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java +++ b/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java @@ -9,8 +9,9 @@ /** * Provides a {@link SplashScreen} to display while Flutter initializes and renders its first frame. * - *

Flutter now automatically keeps the Android launch screen displayed until Flutter has drawn the first frame, and - * thus, there is no longer a need to provide an implementation of this interface. + *

Flutter now automatically keeps the Android launch screen displayed until Flutter has drawn + * the first frame, and thus, there is no longer a need to provide an implementation of this + * interface. * * @deprecated */