This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Fix renderer destructor #28355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27423 introduced a regression even in the non-flatland code because of a member/destruction-order issue. This crash occurs when a flutter app is terminated and the engine instance is shutting down.
While debugging that, I discovered another underlying issue -- all render objects like FuchsiaExternalViewEmbedder are created on raster but destroyed on platform! This is very problematic, especially re: FIDL bindings which must only be accessed on one thread (the destructor logic sends FIDL commands).
Fix both issues.
@uysalere
Tests: Manual testing with workstation (launch simple_browser then quit) and smart_display (session_ctl restart)
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=83473