From fe3a03f72400dc8aa48e736717c96a52fda8ba84 Mon Sep 17 00:00:00 2001 From: asiva Date: Mon, 9 Aug 2021 16:03:05 -0700 Subject: [PATCH 1/3] Enable Dart compressed pointers for 64-bit mobile targets --- tools/gn | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/gn b/tools/gn index 214cc8d02bb6d..fc2e363f303b0 100755 --- a/tools/gn +++ b/tools/gn @@ -380,6 +380,11 @@ def to_gn_args(args): # on Android. gn_args['bssl_use_clang_integrated_as'] = True + # Enable pointer compression on 64-bit mobile targets. + if (args.target_os == 'android' or args.target_os == 'ios') and + (gn_args['target_cpu'] == 'x64' or gn_args['target_cpu'] == 'arm64'): + gn_args['dart_use_compressed_pointers'] = True + return gn_args def parse_args(args): From 64753728ef8f91358d2c6fa12ee56a6012206538 Mon Sep 17 00:00:00 2001 From: asiva Date: Mon, 9 Aug 2021 16:05:46 -0700 Subject: [PATCH 2/3] Fix. --- tools/gn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/gn b/tools/gn index fc2e363f303b0..7e82ced380648 100755 --- a/tools/gn +++ b/tools/gn @@ -381,8 +381,8 @@ def to_gn_args(args): gn_args['bssl_use_clang_integrated_as'] = True # Enable pointer compression on 64-bit mobile targets. - if (args.target_os == 'android' or args.target_os == 'ios') and - (gn_args['target_cpu'] == 'x64' or gn_args['target_cpu'] == 'arm64'): + if (args.target_os == 'android' or args.target_os == 'ios') and ( + gn_args['target_cpu'] == 'x64' or gn_args['target_cpu'] == 'arm64'): gn_args['dart_use_compressed_pointers'] = True return gn_args From c26c1d9c5402509deca464dd38866f3d136b020c Mon Sep 17 00:00:00 2001 From: asiva Date: Tue, 10 Aug 2021 09:25:46 -0700 Subject: [PATCH 3/3] Address code review comments. --- tools/gn | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/gn b/tools/gn index 7e82ced380648..4392174eb4739 100755 --- a/tools/gn +++ b/tools/gn @@ -381,8 +381,7 @@ def to_gn_args(args): gn_args['bssl_use_clang_integrated_as'] = True # Enable pointer compression on 64-bit mobile targets. - if (args.target_os == 'android' or args.target_os == 'ios') and ( - gn_args['target_cpu'] == 'x64' or gn_args['target_cpu'] == 'arm64'): + if args.target_os in ['android', 'ios'] and gn_args['target_cpu'] in ['x64' , 'arm64']: gn_args['dart_use_compressed_pointers'] = True return gn_args