Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix dart analysis #27367

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Fix dart analysis #27367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1072e
fix this
dnfield Jul 13, 2021
58f4642
update docs
dnfield Jul 13, 2021
1d3162a
Update BUILD.gn
dnfield Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/analyze.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function analyze() (
echo "Analyzing dart:ui library..."
analyze \
--options "$FLUTTER_DIR/analysis_options.yaml" \
"$SRC_DIR/out/host_debug_unopt/gen/sky/bindings/dart_ui/ui.dart"
"$SRC_DIR/out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/ui.dart"

echo "Analyzing spirv library..."
analyze \
Expand Down
9 changes: 3 additions & 6 deletions lib/snapshot/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,10 @@ import("//flutter/common/config.gni")
import("//flutter/lib/ui/dart_ui.gni")
import("//third_party/dart/utils/compile_platform.gni")

bindings_output_dir = "$root_gen_dir/sky/bindings"

copy("generate_dart_ui") {
# TODO(dnfield): Remove this when recipes are updated to not use it.
Copy link
Contributor

@chunhtai chunhtai Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which recipes are this refering to? Can you also file an issue for this?

Copy link
Contributor Author

@dnfield dnfield Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LUCI recipes

Copy link
Contributor Author

@dnfield dnfield Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://flutter-review.googlesource.com/c/recipes/+/15420

Copy link
Contributor

@chunhtai chunhtai Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the link in the todo so we know when to clean up this once it merges

Copy link
Contributor Author

@dnfield dnfield Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# https://flutter-review.googlesource.com/c/recipes/+/15420
group("generate_dart_ui") {
visibility = [ ":*" ]
sources = dart_ui_files

outputs = [ "$bindings_output_dir/dart_ui/{{source_file_part}}" ]
}

compiled_action("generate_snapshot_bin") {
Expand Down
10 changes: 8 additions & 2 deletions lib/ui/semantics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,10 +662,16 @@ abstract class StringAttribute extends NativeFieldWrapperClass1 {
required this.range,
});

// The range of the text to which this attribute applies.
/// The range of the text to which this attribute applies.
Copy link
Contributor

@chunhtai chunhtai Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks for fixing this

final TextRange range;

// Returns a copy of this atttribute with the given range.
/// Creates a new attribute with all properties copied except for range, which
/// is updated to the specified value.
///
/// For example, the [LocaleStringAttribute] specifies a [Locale] for its
/// range of characters. Copying it will result in a new
/// [LocaleStringAttribute] that has the same locale but an updated
/// [TextRange].
Copy link
Contributor

@chunhtai chunhtai Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc looks good to me

StringAttribute copy({required TextRange range});
}

Expand Down