Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@harryterkelsen
Copy link
Contributor

The Noto Sans Thai UI font was recently updated on fonts.google.com

Fixes flutter/flutter#85700

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The Noto Sans Thai UI font was recently updated on fonts.google.com
@harryterkelsen harryterkelsen requested a review from yjbanov July 2, 2021 17:52
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jul 2, 2021
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 0977906 into flutter:master Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2021
bdero pushed a commit to flutter/flutter that referenced this pull request Jul 3, 2021
* e94ed1c [web] skip overlay test on Safari (flutter/engine#27114)

* 6b92842 Roll Skia from 1c467774e56e to e9ab391765c7 (1 revision) (flutter/engine#27143)

* 0977906 Update goldens test for Thai. (flutter/engine#27144)

* 4ec5781 [web] replace browser-related conditional logic with BrowserEnvironment (flutter/engine#27084)

* 05ce70e enable DisplayList by default (flutter/engine#27130)

* e3357d2 Roll Fuchsia Mac SDK from jzKy-rCeR... to oiyYFMOd3... (flutter/engine#27145)

* cb1c312 Support right-clicking on iPadOS (flutter/engine#27019)

* 4ac4e5c Roll Fuchsia Linux SDK from 4MLcvcjCH... to QbIpQIqxK... (flutter/engine#27146)

* e6250f7 Roll Skia from e9ab391765c7 to 04d79fc59488 (1 revision) (flutter/engine#27148)

* 2dacffa Revert "enable DisplayList by default (#27130)" (flutter/engine#27153)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
The Noto Sans Thai UI font was recently updated on fonts.google.com
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
The Noto Sans Thai UI font was recently updated on fonts.google.com
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

felt test chrome-unit-linux tests failing; closing tree

2 participants