This repository was archived by the owner on Feb 25, 2025. It is now read-only.
enable DisplayList by default #27130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
chinmaygarde
approved these changes
Jul 2, 2021
zanderso
approved these changes
Jul 2, 2021
flar
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
flar
added a commit
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2021
bdero
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 3, 2021
* e94ed1c [web] skip overlay test on Safari (flutter/engine#27114) * 6b92842 Roll Skia from 1c467774e56e to e9ab391765c7 (1 revision) (flutter/engine#27143) * 0977906 Update goldens test for Thai. (flutter/engine#27144) * 4ec5781 [web] replace browser-related conditional logic with BrowserEnvironment (flutter/engine#27084) * 05ce70e enable DisplayList by default (flutter/engine#27130) * e3357d2 Roll Fuchsia Mac SDK from jzKy-rCeR... to oiyYFMOd3... (flutter/engine#27145) * cb1c312 Support right-clicking on iPadOS (flutter/engine#27019) * 4ac4e5c Roll Fuchsia Linux SDK from 4MLcvcjCH... to QbIpQIqxK... (flutter/engine#27146) * e6250f7 Roll Skia from e9ab391765c7 to 04d79fc59488 (1 revision) (flutter/engine#27148) * 2dacffa Revert "enable DisplayList by default (#27130)" (flutter/engine#27153)
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
This reverts commit 05ce70e.
Member
|
Has this scheduled to reland recently? |
Contributor
Author
|
This change has been landed and reverted a couple of times. I You can also do a search on the flutter/engine PRs for "DisplayList" to see the history. |
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
This reverts commit 05ce70e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable Flutter to use the new DisplayList format for its Picture objects.
I have briefly marked it as a WIP awaiting the original add a DisplayList mechanism PR to percolate up the chain of integrations and pass all of its own testing. When we see it successfully land in the top repos this PR will be pushed to follow it and switch our work over to the new mechanism.
Since it is just changing the default value of a flag, no further tests will be needed and it will hopefully pass all rendering and other tests in the engine and framework repos with no further work.
This change is related to flutter/flutter#53501