This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] replace browser-related conditional logic with BrowserEnvironment #27084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
mdebbar
approved these changes
Jul 1, 2021
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
I love this new structure. Makes much sense!
lib/web_ui/dev/browser.dart
Outdated
| /// | ||
| /// Example file names: | ||
| /// - Chrome, no-suffix: backdrop_filter_clip_moved.actual.png | ||
| /// - iOS Safari: backdrop_filter_clip_moved.actual.iOS_Safari.png |
Contributor
There was a problem hiding this comment.
nit: it should be *.iOS_Safari.actual.png
lib/web_ui/dev/safari_ios.dart
Outdated
| } | ||
|
|
||
| return screenshot; | ||
| /// A class for running an instance of Safari for iOS (i.e. mobile Safari). |
Contributor
There was a problem hiding this comment.
(as you always suggest to me 😁): "A class for" is unnecessary, we already know it's a class. Maybe: "Runs an instance of ..."?
Contributor
Author
There was a problem hiding this comment.
Thanks for rereading the comments. I didn't read the comments for code that I copied (although I should have). Fixed here and a few other places.
lib/web_ui/dev/safari_ios.dart
Outdated
| 'simctl', | ||
| 'openurl', // Opens the url on Safari installed on the simulator. | ||
| 'booted', // The simulator is already booted. | ||
| '${url.toString()}' |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2021
bdero
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 3, 2021
* e94ed1c [web] skip overlay test on Safari (flutter/engine#27114) * 6b92842 Roll Skia from 1c467774e56e to e9ab391765c7 (1 revision) (flutter/engine#27143) * 0977906 Update goldens test for Thai. (flutter/engine#27144) * 4ec5781 [web] replace browser-related conditional logic with BrowserEnvironment (flutter/engine#27084) * 05ce70e enable DisplayList by default (flutter/engine#27130) * e3357d2 Roll Fuchsia Mac SDK from jzKy-rCeR... to oiyYFMOd3... (flutter/engine#27145) * cb1c312 Support right-clicking on iPadOS (flutter/engine#27019) * 4ac4e5c Roll Fuchsia Linux SDK from 4MLcvcjCH... to QbIpQIqxK... (flutter/engine#27146) * e6250f7 Roll Skia from e9ab391765c7 to 04d79fc59488 (1 revision) (flutter/engine#27148) * 2dacffa Revert "enable DisplayList by default (#27130)" (flutter/engine#27153)
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
…nt (flutter#27084) * [web] replace browser-related conditional logic with BrowserEnvironment
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…nt (flutter#27084) * [web] replace browser-related conditional logic with BrowserEnvironment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to deal with browser differences we have relied on conditional logic (
ifblocks) and map look-ups scattered throughout the felt codebase. For example, there would be chunks of code like this:As well as listings and mapping like this.
This PR introduces
BrowserEnvironmentinterface that provides the functionality needed by the test runner. A singleswitchblock at the root (intest_runner.dart) is used to determine a concrete implementation of this interface. The rest of the code no longer needs to deal with browser differences. It just requests the needed functionality fromBrowserEnvironment.As a result all the routing logic from
supported_browsers.dartis gone and the file deleted. Browser-specific implementations ofScreenshotManagerare moved to their respective browser files (chrome.dart,firefox.dart, etc), and thescreenshot_manager.dartfile deleted.The logic in
safari.dartthat attempted to support desktop and mobile Safari visif/elseblocks has been split up intosafari_ios.dartandsafari_macos.dart.The rest of the code was updated to use the
BrowserEnvironmentAPI.Bonus:
do-fetch-goldens-repohas been changed toskip-goldens-repo-fetchto better reflect the default (you opt-in to skip the fetch rather than ask it to fetch).