This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Make window.locale(s) non-null; upgrade to null safe deps #24922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Mar 10, 2021
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.6 | ||
| // @dart = 2.12 |
Contributor
There was a problem hiding this comment.
complains about history and matchers.dart not being null safe to make this change.
Contributor
There was a problem hiding this comment.
We're probably just importing a helper or a constant from history_test.dart. We could move that to another history_helper.dart.
But matchers.dart may require more work since it has even more dependencies.
Contributor
Author
There was a problem hiding this comment.
Done (migrated the helper test libs to null-safety)
yjbanov
force-pushed
the
non-null-locale
branch
from
00a4ff6 to
3ff9889
Compare
yjbanov
changed the title
yjbanov
changed the title
mdebbar
approved these changes
Mar 11, 2021
Comment on lines
+550
to
+554
| @override | ||
| String get pathname => throw UnimplementedError(); | ||
|
|
||
| @override | ||
| String get search => throw UnimplementedError(); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…ter#24922) * Make window.locale(s) non-null * upgrade deps to null-safe; migrate some test libs
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
…ter#24922) * Make window.locale(s) non-null * upgrade deps to null-safe; migrate some test libs
|
Will it be merged into stable 2.0.x or should I wait for the next major stable release? |
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…ter#24922) * Make window.locale(s) non-null * upgrade deps to null-safe; migrate some test libs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#77817