Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Mar 8, 2021

Reverts #24690. It breaks Google internal tests. See b/182201004

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ditman
Copy link
Member

ditman commented Mar 8, 2021

/cc @blasten FYI

@renyou renyou added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 9, 2021
@renyou
Copy link
Contributor Author

renyou commented Mar 9, 2021

Land on red. This revert is clean. It blocks the internal roll. The flakiness of Windows builder is a known problem.

@renyou renyou merged commit 1cbbd11 into master Mar 9, 2021
renyou added a commit to renyou/engine that referenced this pull request Mar 9, 2021
renyou added a commit that referenced this pull request Mar 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2021
renyou added a commit that referenced this pull request Mar 10, 2021
* Revert "Fix memory leak and bug in the RunsOnCreationTaskRunner check (#24690)" (#24874)

This reverts commit 735876e.

* Roll Skia from 07ee548d5bcd to da076e9aca26 (41 revisions) (#24914)

Co-authored-by: skia-flutter-autoroll <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
blasten pushed a commit to blasten/engine that referenced this pull request Mar 30, 2021
@cbracken cbracken deleted the revert-24690-memory_test branch May 10, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants