Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

End composing when inserting text #24866

Merged
merged 1 commit into from
Mar 11, 2021
Merged

End composing when inserting text #24866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ - (void)insertText:(id)string replacementRange:(NSRange)range {
_activeModel->AddText([string UTF8String]);
if (_activeModel->composing()) {
_activeModel->CommitComposing();
_activeModel->EndComposing();
Copy link
Member

@cbracken cbracken Mar 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we may need a [self unmarkText] call as well to let macOS know to bail out of composing mode on its end as well.

}
[self updateEditState];
}
Expand Down