Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move CIPD package creation tools under tools/cipd #24766

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Move CIPD package creation tools under tools/cipd #24766

merged 1 commit into from
Mar 3, 2021

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Mar 3, 2021

This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.

Pre-factoring for flutter/flutter#70205

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Move CIPD package creation tools under tools/cipd
42ccd78 
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
@cbracken cbracken requested a review from blasten March 3, 2021 22:12
@cbracken cbracken merged commit 4aeffbe into flutter:master Mar 3, 2021
@cbracken cbracken deleted the cipd-android branch March 3, 2021 23:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
bb08170 
…gine#24766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
3ca2c14 
…gine#24766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
a41afc7 
…gine#24766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
e19a811 
…gine#24766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
8a8aa79 
…gine#24766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4aeffbe Move CIPD package creation tools under tools/cipd (flutter/en…
9d5c659 
…gine#24766)
cbracken pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
Roll Engine from 72bbc5d to 91120b3 (28 revisions) (#77223)
2f7d9d3 
* aa3bb5e [web] Fix painting of last placeholder in paragraph (flutter/engine#24716)

* a5ae18b [web] Fix pointer events for Wacom pen (flutter/engine#24719)

* 4993c8e Roll Skia from d863ae52d4bb to 036ba86489d7 (3 revisions) (flutter/engine#24732)

* 7f1de85 Roll Dart SDK from f209e60a5415 to 761ed531161f (1 revision) (flutter/engine#24730)

* 44ba1cc Roll Skia from 036ba86489d7 to 786d42c6dac4 (1 revision) (flutter/engine#24733)

* 735876e Fix memory leak and bug in the RunsOnCreationTaskRunner check (flutter/engine#24690)

* 454d29c Roll Skia from 786d42c6dac4 to 12e760e958a7 (10 revisions) (flutter/engine#24738)

* 2c605fd Roll Fuchsia Linux SDK from tJbtmEE4Q... to YhRvbuj9c... (flutter/engine#24739)

* bf97442 Roll Skia from 12e760e958a7 to e80e169ba4c1 (1 revision) (flutter/engine#24740)

* 4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)

* 83b2f8f Roll Fuchsia Mac SDK from PRe0w0i4z... to 4TE5n81B-... (flutter/engine#24745)

* 410dd6f Roll Dart SDK from 761ed531161f to f527ddd39bb1 (3 revisions) (flutter/engine#24746)

* 91d9278 Roll Dart SDK from f527ddd39bb1 to 041a6dd2e76b (1 revision) (flutter/engine#24749)

* 03e0a11 Roll Fuchsia Linux SDK from YhRvbuj9c... to _0kewDFPJ... (flutter/engine#24750)

* f5b1351 Roll Skia from e80e169ba4c1 to acf26501fb5a (4 revisions) (flutter/engine#24752)

* 21de22a Roll Skia from acf26501fb5a to a1e30a3a280a (5 revisions) (flutter/engine#24753)

* e29fd6d Roll Fuchsia Mac SDK from 4TE5n81B-... to kPp_BF0q3... (flutter/engine#24759)

* de78d2a Roll Skia from a1e30a3a280a to f0de96f7b82a (7 revisions) (flutter/engine#24760)

* a33687d Roll Skia from f0de96f7b82a to 46d9bb255df4 (2 revisions) (flutter/engine#24762)

* 95215b7 Roll Dart SDK from 041a6dd2e76b to b9302efc8d9a (3 revisions) (flutter/engine#24764)

* 4aeffbe Move CIPD package creation tools under tools/cipd (flutter/engine#24766)

* 8ef7b63 Roll Skia from 46d9bb255df4 to e4ef35caa1bc (9 revisions) (flutter/engine#24769)

* 4bef5f8 Enables semantics when voice control is turned on (flutter/engine#24640)

* a546f16 Roll Fuchsia Linux SDK from _0kewDFPJ... to _vRi_XkB7... (flutter/engine#24771)

* e31cdad Added dependency on CppWinRT for UWP builds (flutter/engine#24770)

* a5ba994 Roll Skia from e4ef35caa1bc to 4db57264955f (1 revision) (flutter/engine#24772)

* 3cf4f1d Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)

* 91120b3 Roll Skia from 4db57264955f to 21c8ad62cd82 (2 revisions) (flutter/engine#24774)
xster added a commit to xster/engine that referenced this pull request Mar 5, 2021
@xster
update links from flutter#24766
858fe5f
fluttergithubbot pushed a commit that referenced this pull request Mar 10, 2021
@xster
update links from #24766 (#24818)
620b9e4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2021
@engine-flutter-autoroll
620b9e4 update links from flutter/engine#24766 (flutter/engine#24818)
aa230d3
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@cbracken @hjfreyer
Move CIPD package creation tools under tools/cipd (flutter#24766)
311531d 
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@xster @hjfreyer
update links from flutter#24766 (flutter#24818)
c69dd33
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@cbracken @chriscraws
Move CIPD package creation tools under tools/cipd (flutter#24766)
bfc9f70 
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@xster @chriscraws
update links from flutter#24766 (flutter#24818)
a006add
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @blasten @googlebot