Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix UWP build for UpdateCursorRect rename #24697

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix UWP build for UpdateCursorRect rename #24697

merged 1 commit into from
Mar 3, 2021

Conversation

@clarkezone
Copy link

@clarkezone clarkezone commented Mar 1, 2021

Fix UWP build breakage resulting from fix for flutter/flutter#76902

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 1, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Mar 1, 2021
cbracken
cbracken approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks! Sorry for the breakage!

@clarkezone clarkezone merged commit 4d2caac into flutter:master Mar 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
9e477ae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
26ea8a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
a2cd568
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
d148ca5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
efb8e30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
68fd87a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
0a9862a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
74ebee8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
d1ce45a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
f5b3c5e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
715dfa5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
8554a6e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
6a2b215
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
de897c7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
b704102
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
d4dccb9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)
45e2948
cbracken pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
Roll Engine from 72bbc5d to 91120b3 (28 revisions) (#77223)
2f7d9d3 
* aa3bb5e [web] Fix painting of last placeholder in paragraph (flutter/engine#24716)

* a5ae18b [web] Fix pointer events for Wacom pen (flutter/engine#24719)

* 4993c8e Roll Skia from d863ae52d4bb to 036ba86489d7 (3 revisions) (flutter/engine#24732)

* 7f1de85 Roll Dart SDK from f209e60a5415 to 761ed531161f (1 revision) (flutter/engine#24730)

* 44ba1cc Roll Skia from 036ba86489d7 to 786d42c6dac4 (1 revision) (flutter/engine#24733)

* 735876e Fix memory leak and bug in the RunsOnCreationTaskRunner check (flutter/engine#24690)

* 454d29c Roll Skia from 786d42c6dac4 to 12e760e958a7 (10 revisions) (flutter/engine#24738)

* 2c605fd Roll Fuchsia Linux SDK from tJbtmEE4Q... to YhRvbuj9c... (flutter/engine#24739)

* bf97442 Roll Skia from 12e760e958a7 to e80e169ba4c1 (1 revision) (flutter/engine#24740)

* 4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697)

* 83b2f8f Roll Fuchsia Mac SDK from PRe0w0i4z... to 4TE5n81B-... (flutter/engine#24745)

* 410dd6f Roll Dart SDK from 761ed531161f to f527ddd39bb1 (3 revisions) (flutter/engine#24746)

* 91d9278 Roll Dart SDK from f527ddd39bb1 to 041a6dd2e76b (1 revision) (flutter/engine#24749)

* 03e0a11 Roll Fuchsia Linux SDK from YhRvbuj9c... to _0kewDFPJ... (flutter/engine#24750)

* f5b1351 Roll Skia from e80e169ba4c1 to acf26501fb5a (4 revisions) (flutter/engine#24752)

* 21de22a Roll Skia from acf26501fb5a to a1e30a3a280a (5 revisions) (flutter/engine#24753)

* e29fd6d Roll Fuchsia Mac SDK from 4TE5n81B-... to kPp_BF0q3... (flutter/engine#24759)

* de78d2a Roll Skia from a1e30a3a280a to f0de96f7b82a (7 revisions) (flutter/engine#24760)

* a33687d Roll Skia from f0de96f7b82a to 46d9bb255df4 (2 revisions) (flutter/engine#24762)

* 95215b7 Roll Dart SDK from 041a6dd2e76b to b9302efc8d9a (3 revisions) (flutter/engine#24764)

* 4aeffbe Move CIPD package creation tools under tools/cipd (flutter/engine#24766)

* 8ef7b63 Roll Skia from 46d9bb255df4 to e4ef35caa1bc (9 revisions) (flutter/engine#24769)

* 4bef5f8 Enables semantics when voice control is turned on (flutter/engine#24640)

* a546f16 Roll Fuchsia Linux SDK from _0kewDFPJ... to _vRi_XkB7... (flutter/engine#24771)

* e31cdad Added dependency on CppWinRT for UWP builds (flutter/engine#24770)

* a5ba994 Roll Skia from e4ef35caa1bc to 4db57264955f (1 revision) (flutter/engine#24772)

* 3cf4f1d Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)

* 91120b3 Roll Skia from 4db57264955f to 21c8ad62cd82 (2 revisions) (flutter/engine#24774)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@clarkezone @hjfreyer
Fix UWP build for UpdateCursorRect rename (flutter#24697)
2829b24
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@clarkezone @chriscraws
Fix UWP build for UpdateCursorRect rename (flutter#24697)
5162bb1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clarkezone @cbracken