This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll ICU to match the latest version used by Chromium #24673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See #24639 |
Member
|
I remember a previous ICU roll causing issues with the SkParagraph migration. Is there any risk of something like that happening again? |
jason-simmons
force-pushed
the
roll_icu_022621
branch
from
5ca3605 to
3bb3a1e
Compare
Member
Author
|
The previous ICU roll introduced a performance regression that required workarounds in Libtxt and SkParagraph. This roll contains 22 patches. I didn't notice anything suspicious in there, but we should monitor the benchmarks after this lands. |
chinmaygarde
approved these changes
Mar 1, 2021
jason-simmons
force-pushed
the
roll_icu_022621
branch
from
3bb3a1e to
e2bd904
Compare
jason-simmons
force-pushed
the
roll_icu_022621
branch
from
e2bd904 to
e101a59
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.