-
Notifications
You must be signed in to change notification settings - Fork 6k
Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor #24644
Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor #24644
Conversation
f8441e5 to
644c8cc
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dHost in its deconstructor (flutter/engine#24644)
…dHost in its deconstructor (flutter/engine#24644)
…dHost in its deconstructor (flutter/engine#24644)
…dHost in its deconstructor (flutter/engine#24644)
…dHost in its deconstructor (flutter/engine#24644)
|
Is it possible to add a regression test for this? Is there already an integration test that covers this? |
|
@zanderso There isn't an integration test that covers it. There aren't even unit tests for that class. I've found that portion of the engine (android embedder) a bit sparse with respect to tests. I remember having this discussion a couple months ago over another PR here. It might be worth revisiting. |
* Update Dart SDK to 2.12.1 * [canvaskit] fix Path.from (#24382) * Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor (#24644) * update licenses golden Co-authored-by: Yegor <[email protected]> Co-authored-by: gaaclarke <[email protected]>
… its deconstructor (flutter#24644)
… its deconstructor (flutter#24644)
fixes flutter/flutter#76597
There was a typo where we were clearing out a threadhost instead of reseting the reference. I removed the method since
foo->Reset()andfoo.reset()are very similar, in order to avoid future bugs.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.