Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 26, 2021

fixes flutter/flutter#76597

There was a typo where we were clearing out a threadhost instead of reseting the reference. I removed the method since foo->Reset() and foo.reset() are very similar, in order to avoid future bugs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the android-shell-holder-multiple-flutters-fix branch from f8441e5 to 644c8cc Compare February 26, 2021 00:01
@gaaclarke gaaclarke marked this pull request as ready for review February 26, 2021 00:58
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gaaclarke gaaclarke changed the title Android shell holder multiple flutters fix Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor Feb 26, 2021
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke merged commit 95cb19f into flutter:master Feb 26, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2021
@zanderso
Copy link
Member

zanderso commented Mar 9, 2021

Is it possible to add a regression test for this? Is there already an integration test that covers this?

@gaaclarke
Copy link
Member Author

@zanderso There isn't an integration test that covers it. There aren't even unit tests for that class. I've found that portion of the engine (android embedder) a bit sparse with respect to tests. I remember having this discussion a couple months ago over another PR here. It might be worth revisiting.

christopherfujino added a commit that referenced this pull request Mar 10, 2021
* Update Dart SDK to 2.12.1
* [canvaskit] fix Path.from (#24382)
* Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor (#24644)
* update licenses golden

Co-authored-by: Yegor <[email protected]>
Co-authored-by: gaaclarke <[email protected]>
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Flutter Engine: destroy flutter engine making live flutter stop response user interaction

4 participants