From e7f3969afc2a140c204c60f2b4e5cea32a29309e Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Fri, 6 Nov 2020 15:25:53 -0800 Subject: [PATCH 1/3] loadFontFromList returns void no string --- lib/ui/text.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ui/text.dart b/lib/ui/text.dart index d7760b6eb86c3..e69390e9df31e 100644 --- a/lib/ui/text.dart +++ b/lib/ui/text.dart @@ -2299,4 +2299,4 @@ FutureOr _sendFontChangeMessage() async { /// default ascent will be used. /// {@endtemplate} -String _loadFontFromList(Uint8List list, _Callback callback, String? fontFamily) native 'loadFontFromList'; +void _loadFontFromList(Uint8List list, _Callback callback, String? fontFamily) native 'loadFontFromList'; From eb79e561c6cd7af90eb7737a0d6f05db9d387726 Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Fri, 6 Nov 2020 15:50:17 -0800 Subject: [PATCH 2/3] Fix return type --- lib/ui/text.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ui/text.dart b/lib/ui/text.dart index e69390e9df31e..8d10fd9fb287f 100644 --- a/lib/ui/text.dart +++ b/lib/ui/text.dart @@ -2264,7 +2264,9 @@ class ParagraphBuilder extends NativeFieldWrapperClass2 { /// If this is not provided, then the family name will be extracted from the font file. Future loadFontFromList(Uint8List list, {String? fontFamily}) { return _futurize( - (_Callback callback) => _loadFontFromList(list, callback, fontFamily) + (_Callback callback) { + _loadFontFromList(list, callback, fontFamily); + } ).then((_) => _sendFontChangeMessage()); } From 4ffe108085466ea3797d49167075ff90d8f9ee57 Mon Sep 17 00:00:00 2001 From: Emmanuel Garcia Date: Fri, 6 Nov 2020 16:22:42 -0800 Subject: [PATCH 3/3] Retrigger checks