Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Nov 6, 2020

Description

This reverts commit 0d5f2e9.

Due to merge conflicts, this also reverts #22275:

Revert "Do not involve external_view_embedder in submit frame process if threads are not merged. (#22275)"

This reverts commit 016fbde.

Related Issues

flutter/flutter#69983 [tool_crash] RPCError

Tests

n/a

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

)"

This reverts commit 0d5f2e9.

Due to merge conflicts, this also reverts #22275:

Revert "Do not involve external_view_embedder in submit frame process if threads are not merged. (#22275)"

This reverts commit 016fbde.
@cbracken cbracken changed the title Revert "Rasterizer is initialized with an external view embedder (#22… Revert "Rasterizer is initialized with an external view embedder (#22348)" Nov 6, 2020
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 74472ce into flutter:master Nov 6, 2020
@cbracken cbracken deleted the revert branch November 6, 2020 23:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
…tter#22348)" (flutter#22367)

This reverts commit 0d5f2e9.

Due to merge conflicts, this also reverts flutter#22275:

Revert "Do not involve external_view_embedder in submit frame process if threads are not merged. (flutter#22275)"

This reverts commit 016fbde.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants