This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rasterizer is initialized with an external view embedder #22348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
force-pushed
the
rasterizer-use-eve
branch
from
8a3abaa to
f98f4fa
Compare
This allows us to not rely on surface methods for getting the external view embedder.
iskakaushik
force-pushed
the
rasterizer-use-eve
branch
from
f98f4fa to
6f0edb6
Compare
Contributor
Author
|
landing this PR TBR @gaaclarke , @chinmaygarde since this was LGTMed in #22214. When rebasing I missed pushing this comment on top of the change. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Nov 6, 2020
)" Commit flutter/engine#22348 appears to have caused breakage flutter#69983 [tool_crash] RPCError. This reverts commit 9edfa12.
Merged
13 tasks
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2020
…69988) Commit flutter/engine#22348 appears to have caused breakage #69983 [tool_crash] RPCError. This reverts commit 9edfa12.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2020
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
Nov 9, 2020
This allows us to not rely on surface methods for getting the external view embedder. Conflicts: shell/common/rasterizer.cc shell/common/rasterizer_unittests.cc
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
This allows us to not rely on surface methods for getting the external view embedder.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…tter#22348)" (flutter#22367) This reverts commit 0d5f2e9. Due to merge conflicts, this also reverts flutter#22275: Revert "Do not involve external_view_embedder in submit frame process if threads are not merged. (flutter#22275)" This reverts commit 016fbde.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not rely on surface methods for getting the external view embedder.