This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Split the EngineParagraph interface from the legacy implementation #22307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Nov 6, 2020
| final int placeholderCount; | ||
|
|
||
| @override | ||
| double width = -1.0; |
Contributor
There was a problem hiding this comment.
Please add comment on why -1.0.
Contributor
Author
There was a problem hiding this comment.
-1 is the default value in the native engine for non-laid-out paragraph. Added a comment.
| return domElement.clone(true) as html.HtmlElement; | ||
| } | ||
|
|
||
| html.HtmlElement _createDomElement() { |
Contributor
Author
There was a problem hiding this comment.
Added a TODO. Will add in the next PR.
mdebbar
force-pushed
the
split_paragraph
branch
from
765e256 to
d46a52e
Compare
ferhatb
approved these changes
Nov 6, 2020
mdebbar
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new Paragraph implementation that doesn't rely on DOM as an internal representation. The new implementation is still WIP for now, and will be implemented incrementally over multiple PRs.
Related Issues
flutter/flutter#55587