From 235f4050bdcacf6ed17e4fd8632683789daca1af Mon Sep 17 00:00:00 2001
From: Chris Bracken <chris@bracken.jp>
Date: Wed, 14 Oct 2020 17:55:30 -0700
Subject: [PATCH] Add TextRange::Contains tests spanning base/extent

Adds tests for TextRange::Contains(const TextRange&) where the range
being tested spans the base/extent of the testing range.

This was originally intended to land in #21854, but it seems I didn't
push the additional tests before landing.
---
 .../common/cpp/text_range_unittests.cc        | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/shell/platform/common/cpp/text_range_unittests.cc b/shell/platform/common/cpp/text_range_unittests.cc
index 8fcf8fed20534..eaf30d935a515 100644
--- a/shell/platform/common/cpp/text_range_unittests.cc
+++ b/shell/platform/common/cpp/text_range_unittests.cc
@@ -107,6 +107,11 @@ TEST(TextRange, ContainsRangePreStartPosition) {
   EXPECT_FALSE(range.Contains(TextRange(0, 1)));
 }
 
+TEST(TextRange, ContainsRangeSpanningStartPosition) {
+  TextRange range(2, 6);
+  EXPECT_FALSE(range.Contains(TextRange(1, 3)));
+}
+
 TEST(TextRange, ContainsRangeStartPosition) {
   TextRange range(2, 6);
   EXPECT_TRUE(range.Contains(TextRange(2)));
@@ -123,6 +128,11 @@ TEST(TextRange, ContainsRangeEndPosition) {
   EXPECT_TRUE(range.Contains(TextRange(6)));
 }
 
+TEST(TextRange, ContainsRangeSpanningEndPosition) {
+  TextRange range(2, 6);
+  EXPECT_FALSE(range.Contains(TextRange(5, 7)));
+}
+
 TEST(TextRange, ContainsRangePostEndPosition) {
   TextRange range(2, 6);
   EXPECT_FALSE(range.Contains(TextRange(6, 7)));
@@ -133,6 +143,11 @@ TEST(TextRange, ContainsRangePreStartPositionReversed) {
   EXPECT_FALSE(range.Contains(TextRange(0, 1)));
 }
 
+TEST(TextRange, ContainsRangeSpanningStartPositionReversed) {
+  TextRange range(6, 2);
+  EXPECT_FALSE(range.Contains(TextRange(1, 3)));
+}
+
 TEST(TextRange, ContainsRangeStartPositionReversed) {
   TextRange range(6, 2);
   EXPECT_TRUE(range.Contains(TextRange(2)));
@@ -144,6 +159,11 @@ TEST(TextRange, ContainsRangeMiddlePositionReversed) {
   EXPECT_TRUE(range.Contains(TextRange(4, 5)));
 }
 
+TEST(TextRange, ContainsRangeSpanningEndPositionReversed) {
+  TextRange range(6, 2);
+  EXPECT_FALSE(range.Contains(TextRange(5, 7)));
+}
+
 TEST(TextRange, ContainsRangeEndPositionReversed) {
   TextRange range(6, 2);
   EXPECT_TRUE(range.Contains(TextRange(5)));