From 7d2d94bac146f5144ff11847ba1c325a7c41ba8b Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Thu, 24 Sep 2020 20:44:07 -0700 Subject: [PATCH 1/2] Remove ASCII art from mDNS error log --- .../ios/framework/Source/FlutterObservatoryPublisher.mm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm b/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm index 2f5655775e744..ca79a60f2d8a1 100644 --- a/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm +++ b/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm @@ -115,18 +115,16 @@ - (void)publishServiceProtocolPort:(NSString*)uri { FML_LOG(ERROR) << "Failed to register observatory port with mDNS with error " << err << "."; if (@available(iOS 14.0, *)) { FML_LOG(ERROR) - << "▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒\n" << "On iOS 14+, local network broadcast in apps need to be declared in " << "the app's Info.plist. Debug and profile Flutter apps and modules host " << "VM services on the local network to support debugging features such " - << "as hot reload and DevTools.\n\nTo make your Flutter app or module " + << "as hot reload and DevTools. To make your Flutter app or module " << "attachable and debuggable, add a '" << registrationType << "' value " << "to the 'NSBonjourServices' key in your Info.plist for the Debug/" - << "Profile configurations.\n\n" + << "Profile configurations. " << "For more information, see " // Update link to a specific header as needed. - << "https://flutter.dev/docs/development/add-to-app/ios/project-setup" - << "\n▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒"; + << "https://flutter.dev/docs/development/add-to-app/ios/project-setup"; } } else { DNSServiceSetDispatchQueue(_dnsServiceRef, dispatch_get_main_queue()); From edf770036c8417215d2834b7bd02945ddcdf09ff Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Fri, 25 Sep 2020 10:12:00 -0700 Subject: [PATCH 2/2] Format --- .../Source/FlutterObservatoryPublisher.mm | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm b/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm index ca79a60f2d8a1..072a244a967fc 100644 --- a/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm +++ b/shell/platform/darwin/ios/framework/Source/FlutterObservatoryPublisher.mm @@ -114,17 +114,16 @@ - (void)publishServiceProtocolPort:(NSString*)uri { if (err != 0) { FML_LOG(ERROR) << "Failed to register observatory port with mDNS with error " << err << "."; if (@available(iOS 14.0, *)) { - FML_LOG(ERROR) - << "On iOS 14+, local network broadcast in apps need to be declared in " - << "the app's Info.plist. Debug and profile Flutter apps and modules host " - << "VM services on the local network to support debugging features such " - << "as hot reload and DevTools. To make your Flutter app or module " - << "attachable and debuggable, add a '" << registrationType << "' value " - << "to the 'NSBonjourServices' key in your Info.plist for the Debug/" - << "Profile configurations. " - << "For more information, see " - // Update link to a specific header as needed. - << "https://flutter.dev/docs/development/add-to-app/ios/project-setup"; + FML_LOG(ERROR) << "On iOS 14+, local network broadcast in apps need to be declared in " + << "the app's Info.plist. Debug and profile Flutter apps and modules host " + << "VM services on the local network to support debugging features such " + << "as hot reload and DevTools. To make your Flutter app or module " + << "attachable and debuggable, add a '" << registrationType << "' value " + << "to the 'NSBonjourServices' key in your Info.plist for the Debug/" + << "Profile configurations. " + << "For more information, see " + // Update link to a specific header as needed. + << "https://flutter.dev/docs/development/add-to-app/ios/project-setup"; } } else { DNSServiceSetDispatchQueue(_dnsServiceRef, dispatch_get_main_queue());