From e092ce3facefec7ec0d9bd42b5cebbc7e5e4eafc Mon Sep 17 00:00:00 2001 From: Keyong Han Date: Wed, 12 Aug 2020 14:40:23 -0700 Subject: [PATCH 1/3] add enabled flag --- ci/dev/README.md | 21 +++++++++++++++------ ci/dev/try_builders.json | 39 ++++++++++++++++++++++++++------------- 2 files changed, 41 insertions(+), 19 deletions(-) diff --git a/ci/dev/README.md b/ci/dev/README.md index fe2a07712bd60..6f83b972ad59a 100644 --- a/ci/dev/README.md +++ b/ci/dev/README.md @@ -9,15 +9,24 @@ supported luci try/prod builders for engine. It follows format: "builders":[ { "name":"xxx", - "repo":"engine" - }, + "repo":"engine", + "enabled":true + } + ] +} +``` +for `try_builders.json`, and follows format: +```json +{ + "builders":[ { - "name":"yyy", + "name":"xxx", "repo":"engine" } ] } ``` -This file will be mainly used in [`flutter/cocoon`](https://github.com/flutter/cocoon) -to trigger/update engine luci tasks. - +for `prod_builders.json`. `try_builders.json` will be mainly used in +[`flutter/cocoon`](https://github.com/flutter/cocoon) to trigger/update pre-submit +engine luci tasks, whereas `prod_builders.json` will be mainly used in `flutter/cocoon` +to push luci task statuses to GitHub. \ No newline at end of file diff --git a/ci/dev/try_builders.json b/ci/dev/try_builders.json index 96645687931b2..d74ffb5d3b8c8 100644 --- a/ci/dev/try_builders.json +++ b/ci/dev/try_builders.json @@ -2,55 +2,68 @@ "builders":[ { "name":"Linux Host Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Linux Fuchsia", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Linux Android AOT Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Linux Android Debug Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Linux Web Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Mac Host Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Mac Android AOT Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Mac Android Debug Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Mac iOS Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Windows Host Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Windows Android AOT Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Windows Web Engine", - "repo":"engine" + "repo":"engine", + "enabled": true }, { "name":"Mac Web Engine", - "repo":"engine" + "repo":"engine", + "enabled": true } ] } From 01394b56011340a711485ae24a8193e301d58201 Mon Sep 17 00:00:00 2001 From: Keyong Han Date: Thu, 13 Aug 2020 09:27:19 -0700 Subject: [PATCH 2/3] update doc --- ci/dev/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/dev/README.md b/ci/dev/README.md index 6f83b972ad59a..e66a6120d6660 100644 --- a/ci/dev/README.md +++ b/ci/dev/README.md @@ -20,7 +20,7 @@ for `try_builders.json`, and follows format: { "builders":[ { - "name":"xxx", + "name":"yyy", "repo":"engine" } ] From d8d5706a70f9ae836890d872f92c9b1be52c2a32 Mon Sep 17 00:00:00 2001 From: Keyong Han Date: Thu, 13 Aug 2020 09:41:33 -0700 Subject: [PATCH 3/3] update doc --- ci/dev/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/dev/README.md b/ci/dev/README.md index e66a6120d6660..6f5701397bfe6 100644 --- a/ci/dev/README.md +++ b/ci/dev/README.md @@ -8,7 +8,7 @@ supported luci try/prod builders for engine. It follows format: { "builders":[ { - "name":"xxx", + "name":"yyy", "repo":"engine", "enabled":true }