Made [SemanticsObject setAccessibilityContainer] a noop.

[gaaclarke]

Description

On iOS 9 setAccessibilityContainer is getting called in the init for UIAccessibilityElement which is contrary to the design of SemanticsObject since it was originally an NSObject. I've made the setter a noop to just rely on the logic from the getter.

Related Issues

flutter/flutter#54366

Tests

This is covered by current tests, but only manifests on iOS 9.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the contributor guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the C++, Objective-C, Java style guides for the engine.
• I read the tree hygiene wiki page, which explains my responsibilities.
• I updated/added relevant documentation.
• All existing and new tests are passing.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

• No, no existing tests failed, so this is not a breaking change.
• Yes, this is a breaking change. If not, delete the remainder of this section.
  • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
  • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
  • I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

[fluttergithubbot]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[nscobie]

I don't see anything obviously wrong, but I'm not familiar with this yet so I would be interested in what Dan says and the results of the manual testing you requested in #54366.

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

QQ: Will this block the merge, or is it more of a soft requirement not enforced by an automated system?

Tentative LGTM. :-)

[dnfield]

@nscobie it's just a reminder to reviewers and authors.

Is there any way we can add a test for this?

[CareF]

Tested under iPhone 4s with iOS 9.3.5 and voiceover on. Works fine.

[gaaclarke]

@dnfield we already have tests for it, we just can't run it on iOS 9. Xcode doesn't support iOS 9 anymore so we'd have to create infrastructure to support running it with an old version of xcode or on a device.

[dnfield]

LGTM to unblock customer