[iOS] Called platform view only once #19206

zhongwuzw · 2020-06-22T11:51:07Z

Description

Users may return a newly created embedded view when call view method of FlutterPlatformView protocol. After #17336, we call view method of FlutterPlatformView protocol multiple times, causes GetPlatformViewRect return incorrect rect.

Related Issues

flutter/flutter#59751

Tests

I added the following tests:

N/A.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

fluttergithubbot · 2020-06-22T11:51:09Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

nturgut · 2020-06-24T17:56:04Z

Can you please rebase to head? I added a recipe change to the Web Engine but it needs the most recent code to run. Sorry for the inconvenience.

…calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204) This reverts commit f5c315f.

…9161)

* firefox integration tests enable * addressing reviewer comments

…19109) The Fuchsia artifact builder didn't allow the end user to add more packages to build for Fuchsia. The current default is building only the platform-specific packages; but packages like `flutter/shell/common:shell_tests` are also defined for Fuchsia but not compiled by default. This change makes it less of a hassle to compile such packages.

…calculate the final bounding rect for platform view flutter#19170" (flutter#19212)

…utter#19221)

…er#19226)" (flutter#19228) This reverts commit 2bf51b3.

* change the version of simulator. luci bots only has 13.0 * skip failing pointer binding tests * skip path_metrics (canvaskit) and a method from surface_test * fix analyzer errors * remove extra added touch event context test * removing left overs for screenshot debugging * apply reviewers suggestion for skipping tests

…iew on demand (flutter#19279)

googlebot · 2020-06-25T00:00:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-06-25T00:00:36Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

zhongwuzw · 2020-06-25T00:13:14Z

@nturgut Seems I did the wrong operations to mess the commits, I open a new Pr, please check that #19292.

zhongwuzw added 2 commits June 22, 2020 16:19

[iOS] Fixes accessibilityIdentifier of platform views

f3a1040

Call embedded view only once

31ac8b6

fluttergithubbot added the platform-ios label Jun 22, 2020

googlebot added the cla: yes label Jun 22, 2020

auto-assign bot requested a review from flar June 22, 2020 11:53

Fix typo

bbe8615

brianosman and others added 22 commits June 25, 2020 07:59

Revert "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

9325351

…calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204) This reverts commit f5c315f.

Roll Dart SDK from 9fcac03 to cc5df58 (22 revisions) (flutter#19207)

72a0120

Roll Skia from 50daedd to 956ec8a (5 revisions) (flutter#19208)

b1a90fe

Roll Fuchsia Linux SDK from gaCdq... to oldar... (flutter#19209)

dfc3b8c

Fix fonts.clear exception in IE11 (flutter#19180)

ea1ed12

[iOS] text input methods to only call updateEditState once (flutter#1…

f042721

…9161)

Roll Skia from 956ec8a to abe2375 (5 revisions) (flutter#19215)

2eb73ad

Enable firefox integration tests (flutter#19164)

8b444d2

* firefox integration tests enable * addressing reviewer comments

Roll Dart SDK from cc5df58 to d872aea (8 revisions) (flutter#19216)

c4ba6f7

Roll Fuchsia Mac SDK from thz2_... to LRcV-... (flutter#19217)

3c5533f

Roll Skia from abe2375 to 3cf3d92 (5 revisions) (flutter#19218)

b9f3ccf

Creates a new RenderMode for FlutterView (flutter#19143)

8703ccd

Reland "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

120a32f

…calculate the final bounding rect for platform view flutter#19170" (flutter#19212)

JNI glue for calling PlatformViewsController.createOverlaySurface (fl…

febe307

…utter#19221)

Roll Skia from 3cf3d92 to 6dd62cb (4 revisions) (flutter#19222)

67caf4e

Roll Skia from 6dd62cb to b444943 (1 revision) (flutter#19225)

63d77f6

Roll Dart SDK from d872aea to 2d22e4c (14 revisions) (flutter#19227)

9f1aa25

Implement PlatformViewsController.createOverlaySurface (flutter#19226)

036383a

Revert "Implement PlatformViewsController.createOverlaySurface (flutt…

b1f71bb

…er#19226)" (flutter#19228) This reverts commit 2bf51b3.

Roll Fuchsia Linux SDK from oldar... to RGOLO... (flutter#19229)

f6ed9dd

Roll Skia from b444943 to fc25346 (1 revision) (flutter#19230)

9d1f724

nturgut and others added 24 commits June 25, 2020 07:59

Roll Skia from 3b6b747 to fe02dd1 (5 revisions) (flutter#19248)

5c187f9

Roll Fuchsia Mac SDK from MvXLH... to -UZgg... (flutter#19250)

c153faa

Roll Skia from fe02dd1 to 5aaaeea (1 revision) (flutter#19251)

acc6eff

Roll Skia from 5aaaeea to 22f246f (1 revision) (flutter#19256)

535d4da

Made [SemanticsObject setAccessibilityContainer] a noop. (flutter#19249)

219898a

Roll Skia from 22f246f to a3b0b30 (1 revision) (flutter#19259)

1e9061a

Roll Skia from a3b0b30 to 92c3b89 (1 revision) (flutter#19262)

2fe162b

Roll Dart SDK from 6b630c3 to 05167f3 (16 revisions) (flutter#19263)

5d5eeea

Roll Skia from 92c3b89 to 322e4be (2 revisions) (flutter#19264)

aea63fc

Roll Fuchsia Linux SDK from 3lfit... to 6Dz_3... (flutter#19265)

e67e2d0

Roll Dart SDK from 05167f3 to b414716 (2 revisions) (flutter#19268)

d0fd7b5

Roll Fuchsia Mac SDK from -UZgg... to l2ubU... (flutter#19269)

641ce34

Roll Dart SDK from b414716 to d8eb844 (5 revisions) (flutter#19272)

935730f

Fix format (flutter#19261)

78fa47a

Move OnDisplayPlatformView JNI call (flutter#19258)

750f999

Update README.md (flutter#19275)

04d601a

Roll Skia from 322e4be to 8ee607c (17 revisions) (flutter#19274)

f8d0225

EndFrame should be always called by rasterizer (flutter#19257)

9a22f1c

Android platform view static thread merging (flutter#19242)

cc02baa

Roll Skia from 8ee607c to 632db1c (8 revisions) (flutter#19284)

c181522

Make Shell::NotifyLowMemoryWarning trace (flutter#19283)

b26b60d

Roll Fuchsia Linux SDK from 6Dz_3... to GqEvV... (flutter#19285)

5232243

Initial work toward converting the FlutterView to use a FlutterImageV…

1d458e5

…iew on demand (flutter#19279)

googlebot added cla: no and removed cla: yes labels Jun 25, 2020

zhongwuzw closed this Jun 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[iOS] Called platform view only once #19206

[iOS] Called platform view only once #19206

Uh oh!

zhongwuzw commented Jun 22, 2020 •

edited

Loading

Uh oh!

fluttergithubbot commented Jun 22, 2020

Uh oh!

nturgut commented Jun 24, 2020

Uh oh!

googlebot commented Jun 25, 2020

Uh oh!

googlebot commented Jun 25, 2020

Uh oh!

zhongwuzw commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

[iOS] Called platform view only once #19206

[iOS] Called platform view only once #19206

Uh oh!

Conversation

zhongwuzw commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented Jun 22, 2020

Uh oh!

nturgut commented Jun 24, 2020

Uh oh!

googlebot commented Jun 25, 2020

Uh oh!

googlebot commented Jun 25, 2020

Uh oh!

zhongwuzw commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

zhongwuzw commented Jun 22, 2020 •

edited

Loading