Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

gpu_metal_surface submitframe return false when canvas is null #18154

Merged
merged 2 commits into from
May 6, 2020
Merged

gpu_metal_surface submitframe return false when canvas is null #18154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8b348
return false in submitframe callback if the canvas is not available
May 5, 2020
68aec35
add dlogs
May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions shell/gpu/gpu_surface_metal.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@

auto submit_callback = [this](const SurfaceFrame& surface_frame, SkCanvas* canvas) -> bool {
TRACE_EVENT0("flutter", "GPUSurfaceMetal::Submit");
if (canvas == nullptr) {
FML_DLOG(ERROR) << "Canvas not available.";
return false;
Copy link
Member

@chinmaygarde chinmaygarde May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add a DLOG like in the other case of an early return?

Copy link
Contributor Author

@cyanglaz cyanglaz May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added log and created an issue flutter/flutter#56405

}

canvas->flush();

if (next_drawable_ == nullptr) {
Expand Down