This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix multi-reply on message channel. Add test #17591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
reviewed
Apr 8, 2020
| key: const Key('input'), | ||
| enabled: true, | ||
| controller: _controller, | ||
| //initialValue: 'Text1', |
Contributor
There was a problem hiding this comment.
I think this is a leftover from my code. I also saw it yesterday. Can you remove this line :)
Contributor
Author
There was a problem hiding this comment.
Clarified why we need text field with comment.
nturgut
reviewed
Apr 8, 2020
| void main() async { | ||
| E2EWidgetsFlutterBinding.ensureInitialized() as E2EWidgetsFlutterBinding; | ||
|
|
||
| testWidgets('platform message for Clipboard.set/getData reply with future', |
Contributor
There was a problem hiding this comment.
nit: Rename the test. I think we only tests the setData here.
nturgut
reviewed
Apr 8, 2020
| }).catchError((dynamic _) { | ||
| callback(codec.encodeErrorEnvelope( | ||
| code: 'copy_fail', message: 'Clipboard.setData failed')); | ||
| // Don't encode a duplicate reply if we already failed and an error |
nturgut
approved these changes
Apr 8, 2020
mdebbar
approved these changes
Apr 8, 2020
Comment on lines
28
to
+30
| callback(codec.encodeErrorEnvelope( | ||
| code: 'copy_fail', message: 'Clipboard.setData failed')); | ||
| errorEnvelopeEncoded = true; |
Contributor
There was a problem hiding this comment.
There's no error thrown here. Why would the catchError callback be invoked after this?
Contributor
Author
There was a problem hiding this comment.
When you do the error reply, the code that handles it could/did crash, then that is caught and instead of stack trace of error handling code that failed, you get the multi-reply failure.
ditman
approved these changes
Apr 8, 2020
e2etests/web/regular_integration_tests/test_driver/platform_messages_e2e.dart
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2020
This was referenced Apr 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* Fix multi-reply on message channel. Add test * Add check for viewInstanceCount * skip no-headless test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: flutter/flutter#53367