From 9448f1c2151340cd716fe188c992ec060846fa2f Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Tue, 7 Apr 2020 21:24:45 -0700 Subject: [PATCH 1/4] Add logs between fuchsia test steps. Adding logs and date time in between steps will simplify finding the steps that are failing during the fuchsia tests. https://github.com/flutter/flutter/issues/54253 --- testing/fuchsia/run_tests.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/testing/fuchsia/run_tests.sh b/testing/fuchsia/run_tests.sh index 90eb36ab8e486..d86367f136b7b 100755 --- a/testing/fuchsia/run_tests.sh +++ b/testing/fuchsia/run_tests.sh @@ -36,18 +36,24 @@ reboot() { trap reboot EXIT +echo "$(DATE) -----------START:PAVING----------------" ./fuchsia_ctl -d $device_name pave -i $1 +echo "$(DATE) -----------END:PAVING----------------" +echo "$(DATE) -----------START:WAIT_DEVICE_READY----------------" for i in {1..10}; do ./fuchsia_ctl -d $device_name ssh -c "echo up" && break || sleep 15; done +echo "$(DATE) -----------END:WAIT_DEVICE_READY----------------" # TODO(gw280): Enable tests using JIT runner +echo "$(DATE) -----------START:flutter_runner_tests----------------" ./fuchsia_ctl -d $device_name test \ -f flutter_aot_runner-0.far \ -f flutter_runner_tests-0.far \ -t flutter_runner_tests +echo "$(DATE) -----------END:flutter_runner_tests----------------" # TODO(https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47081) # Re-enable once the crash is resolved @@ -58,23 +64,26 @@ done # TODO(https://github.com/flutter/flutter/issues/50032) Enable after the # Fuchsia message loop migration is complete. +echo "$(DATE) -----------START:fml_tests----------------" ./fuchsia_ctl -d $device_name test \ -f fml_tests-0.far \ -t fml_tests \ -a "--gtest_filter=-MessageLoop*:Message*:FileTest*" +echo "$(DATE) -----------START:flow_tests----------------" ./fuchsia_ctl -d $device_name test \ -f flow_tests-0.far \ -t flow_tests +echo "$(DATE) -----------START:runtime_tests----------------" ./fuchsia_ctl -d $device_name test \ -f runtime_tests-0.far \ -t runtime_tests # TODO(https://github.com/flutter/flutter/issues/53399): Re-enable # OnServiceProtocolGetSkSLsWorks once it passes on Fuchsia. +echo "$(DATE) -----------START:shell_tests----------------" ./fuchsia_ctl -d $device_name test \ -f shell_tests-0.far \ -t shell_tests \ -a "--gtest_filter=-ShellTest.CacheSkSLWorks:ShellTest.SetResourceCacheSize*:ShellTest.OnServiceProtocolGetSkSLsWorks" - From a0a95919e52c3cffcf2ab8bedff7614b6cec0869 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Tue, 7 Apr 2020 22:00:41 -0700 Subject: [PATCH 2/4] Use date command instead of DATE.. --- testing/fuchsia/run_tests.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/testing/fuchsia/run_tests.sh b/testing/fuchsia/run_tests.sh index d86367f136b7b..87d8ba4333ed2 100755 --- a/testing/fuchsia/run_tests.sh +++ b/testing/fuchsia/run_tests.sh @@ -36,24 +36,24 @@ reboot() { trap reboot EXIT -echo "$(DATE) -----------START:PAVING----------------" +echo "$(date) -----------START:PAVING----------------" ./fuchsia_ctl -d $device_name pave -i $1 -echo "$(DATE) -----------END:PAVING----------------" +echo "$(date) -----------END:PAVING----------------" -echo "$(DATE) -----------START:WAIT_DEVICE_READY----------------" +echo "$(date) -----------START:WAIT_DEVICE_READY----------------" for i in {1..10}; do ./fuchsia_ctl -d $device_name ssh -c "echo up" && break || sleep 15; done -echo "$(DATE) -----------END:WAIT_DEVICE_READY----------------" +echo "$(date) -----------END:WAIT_DEVICE_READY----------------" # TODO(gw280): Enable tests using JIT runner -echo "$(DATE) -----------START:flutter_runner_tests----------------" +echo "$(date) -----------START:flutter_runner_tests----------------" ./fuchsia_ctl -d $device_name test \ -f flutter_aot_runner-0.far \ -f flutter_runner_tests-0.far \ -t flutter_runner_tests -echo "$(DATE) -----------END:flutter_runner_tests----------------" +echo "$(date) -----------END:flutter_runner_tests----------------" # TODO(https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47081) # Re-enable once the crash is resolved @@ -64,25 +64,25 @@ echo "$(DATE) -----------END:flutter_runner_tests----------------" # TODO(https://github.com/flutter/flutter/issues/50032) Enable after the # Fuchsia message loop migration is complete. -echo "$(DATE) -----------START:fml_tests----------------" +echo "$(date) -----------START:fml_tests----------------" ./fuchsia_ctl -d $device_name test \ -f fml_tests-0.far \ -t fml_tests \ -a "--gtest_filter=-MessageLoop*:Message*:FileTest*" -echo "$(DATE) -----------START:flow_tests----------------" +echo "$(date) -----------START:flow_tests----------------" ./fuchsia_ctl -d $device_name test \ -f flow_tests-0.far \ -t flow_tests -echo "$(DATE) -----------START:runtime_tests----------------" +echo "$(date) -----------START:runtime_tests----------------" ./fuchsia_ctl -d $device_name test \ -f runtime_tests-0.far \ -t runtime_tests # TODO(https://github.com/flutter/flutter/issues/53399): Re-enable # OnServiceProtocolGetSkSLsWorks once it passes on Fuchsia. -echo "$(DATE) -----------START:shell_tests----------------" +echo "$(date) -----------START:shell_tests----------------" ./fuchsia_ctl -d $device_name test \ -f shell_tests-0.far \ -t shell_tests \ From 43121be85d55c21d711e7c301850205680e55b36 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Tue, 7 Apr 2020 22:23:15 -0700 Subject: [PATCH 3/4] Remove extra log line. --- testing/fuchsia/run_tests.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/testing/fuchsia/run_tests.sh b/testing/fuchsia/run_tests.sh index 87d8ba4333ed2..24bb774ad93b9 100755 --- a/testing/fuchsia/run_tests.sh +++ b/testing/fuchsia/run_tests.sh @@ -53,7 +53,6 @@ echo "$(date) -----------START:flutter_runner_tests----------------" -f flutter_aot_runner-0.far \ -f flutter_runner_tests-0.far \ -t flutter_runner_tests -echo "$(date) -----------END:flutter_runner_tests----------------" # TODO(https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47081) # Re-enable once the crash is resolved From 72e31715f851b6ea147b7cf2367ee3070b7bd3cc Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 8 Apr 2020 10:29:21 -0700 Subject: [PATCH 4/4] Same spacer lenght for all the log lines. --- testing/fuchsia/run_tests.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/testing/fuchsia/run_tests.sh b/testing/fuchsia/run_tests.sh index 24bb774ad93b9..5b40eb4e846fb 100755 --- a/testing/fuchsia/run_tests.sh +++ b/testing/fuchsia/run_tests.sh @@ -36,19 +36,19 @@ reboot() { trap reboot EXIT -echo "$(date) -----------START:PAVING----------------" +echo "$(date) START:PAVING ------------------------------------------" ./fuchsia_ctl -d $device_name pave -i $1 -echo "$(date) -----------END:PAVING----------------" +echo "$(date) END:PAVING --------------------------------------------" -echo "$(date) -----------START:WAIT_DEVICE_READY----------------" +echo "$(date) START:WAIT_DEVICE_READY -------------------------------" for i in {1..10}; do ./fuchsia_ctl -d $device_name ssh -c "echo up" && break || sleep 15; done -echo "$(date) -----------END:WAIT_DEVICE_READY----------------" +echo "$(date) END:WAIT_DEVICE_READY ---------------------------------" # TODO(gw280): Enable tests using JIT runner -echo "$(date) -----------START:flutter_runner_tests----------------" +echo "$(date) START:flutter_runner_tests ----------------------------" ./fuchsia_ctl -d $device_name test \ -f flutter_aot_runner-0.far \ -f flutter_runner_tests-0.far \ @@ -63,25 +63,25 @@ echo "$(date) -----------START:flutter_runner_tests----------------" # TODO(https://github.com/flutter/flutter/issues/50032) Enable after the # Fuchsia message loop migration is complete. -echo "$(date) -----------START:fml_tests----------------" +echo "$(date) START:fml_tests ---------------------------------------" ./fuchsia_ctl -d $device_name test \ -f fml_tests-0.far \ -t fml_tests \ -a "--gtest_filter=-MessageLoop*:Message*:FileTest*" -echo "$(date) -----------START:flow_tests----------------" +echo "$(date) START:flow_tests --------------------------------------" ./fuchsia_ctl -d $device_name test \ -f flow_tests-0.far \ -t flow_tests -echo "$(date) -----------START:runtime_tests----------------" +echo "$(date) START:runtime_tests -----------------------------------" ./fuchsia_ctl -d $device_name test \ -f runtime_tests-0.far \ -t runtime_tests # TODO(https://github.com/flutter/flutter/issues/53399): Re-enable # OnServiceProtocolGetSkSLsWorks once it passes on Fuchsia. -echo "$(date) -----------START:shell_tests----------------" +echo "$(date) START:shell_tests -------------------------------------" ./fuchsia_ctl -d $device_name test \ -f shell_tests-0.far \ -t shell_tests \