From 22dffd3328a16586e4aa1d163e1a9132150667cf Mon Sep 17 00:00:00 2001 From: Nurhan Turgut <50856934+nturgut@users.noreply.github.com> Date: Wed, 18 Dec 2019 17:04:36 -0800 Subject: [PATCH 1/2] instructions for running firefox/safari tests --- lib/web_ui/dev/README.md | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/lib/web_ui/dev/README.md b/lib/web_ui/dev/README.md index 8a1ff65f3f058..ec28a82ca71fb 100644 --- a/lib/web_ui/dev/README.md +++ b/lib/web_ui/dev/README.md @@ -31,17 +31,34 @@ felt build [-w] -j 100 If you are a Google employee, you can use an internal instance of Goma to parallelize your builds. Because Goma compiles code on remote servers, this option is effective even on low-powered laptops. ## Running web engine tests -To run all tests: +To run all tests on Chrome: ``` felt test ``` +To run tests on Firefox (this will work on a Linux device): + +``` +felt test --browser=firefox +``` + +For Chrome and Firefox, the tests run on a version locked on the [browser_lock.yaml](https://github.com/flutter/engine/blob/master/lib/web_ui/dev/browser_lock.yaml). In order to use another version, add the version argument: + +``` +felt test --browser=firefox --firefox-version=70.0.1 +``` + +To run tests on Safari use the following command. It works on MacOS devices and it uses the Safari installed on the OS. Currently there is no option for using another Safari version. + +``` +felt test --browser=safari +``` To run a single test: ``` felt test test/golden_tests/engine/canvas_golden_test.dart ``` -To debug a test: +To debug a test on Chrome: ``` felt test --debug test/golden_tests/engine/canvas_golden_test.dart ``` From 2a024c41a359d188d6c370ff2325759b196da609 Mon Sep 17 00:00:00 2001 From: Nurhan Turgut <50856934+nturgut@users.noreply.github.com> Date: Wed, 18 Dec 2019 17:21:52 -0800 Subject: [PATCH 2/2] addressing reviewer comments. --- lib/web_ui/dev/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/web_ui/dev/README.md b/lib/web_ui/dev/README.md index ec28a82ca71fb..86e06ccde8f04 100644 --- a/lib/web_ui/dev/README.md +++ b/lib/web_ui/dev/README.md @@ -32,10 +32,12 @@ If you are a Google employee, you can use an internal instance of Goma to parall ## Running web engine tests To run all tests on Chrome: + ``` felt test ``` -To run tests on Firefox (this will work on a Linux device): + +To run tests on Firefox (this will work only on a Linux device): ``` felt test --browser=firefox