flutter$ ./ci/lint.sh --lint-all --variant host_debug ┌──────────────────────────┐ │ Engine Clang Tidy Linter │ └──────────────────────────┘ The following errors have been reported by the Engine Clang Tidy Linter. For more information on addressing these issues please see: https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter 🔶 linting flutter/assets/asset_manager.cc 🔶 linting flutter/assets/directory_asset_bundle.cc 🔶 linting flutter/benchmarking/benchmarking.cc 🔶 linting flutter/common/settings.cc 🔶 linting flutter/common/task_runners.cc 🔶 linting flutter/common/graphics/gl_context_switch.cc 🔶 linting flutter/common/graphics/persistent_cache.cc 🔶 linting flutter/common/graphics/texture.cc 🔶 linting flutter/display_list/display_list.cc 🔶 linting flutter/display_list/display_list_builder.cc 🔶 linting flutter/display_list/display_list_canvas_dispatcher.cc 🔶 linting flutter/display_list/display_list_canvas_recorder.cc 🔶 linting flutter/display_list/display_list_complexity.cc 🔶 linting flutter/display_list/display_list_dispatcher.cc 🔶 linting flutter/display_list/display_list_flags.cc 🔶 linting flutter/display_list/display_list_ops.cc 🔶 linting flutter/display_list/display_list_utils.cc 🔶 linting flutter/display_list/display_list_benchmarks.cc 🔶 linting flutter/display_list/display_list_benchmarks_software.cc 🔶 linting flutter/display_list/display_list_benchmarks_gl.cc 🔶 linting flutter/display_list/display_list_benchmarks_metal.cc 🔶 linting flutter/display_list/display_list_canvas_unittests.cc 🔶 linting flutter/display_list/display_list_unittests.cc 🔶 linting flutter/flow/compositor_context.cc 🔶 linting flutter/flow/diff_context.cc 🔶 linting flutter/flow/embedded_views.cc 🔶 linting flutter/flow/frame_timings.cc 🔶 linting flutter/flow/instrumentation.cc 🔶 linting flutter/flow/layers/backdrop_filter_layer.cc 🔶 linting flutter/flow/layers/clip_path_layer.cc 🔶 linting flutter/flow/layers/clip_rect_layer.cc 🔶 linting flutter/flow/layers/clip_rrect_layer.cc 🔶 linting flutter/flow/layers/color_filter_layer.cc 🔶 linting flutter/flow/layers/container_layer.cc 🔶 linting flutter/flow/layers/display_list_layer.cc 🔶 linting flutter/flow/layers/image_filter_layer.cc 🔶 linting flutter/flow/layers/layer.cc 🔶 linting flutter/flow/layers/layer_tree.cc 🔶 linting flutter/flow/layers/opacity_layer.cc 🔶 linting flutter/flow/layers/performance_overlay_layer.cc 🔶 linting flutter/flow/layers/physical_shape_layer.cc 🔶 linting flutter/flow/layers/picture_layer.cc 🔶 linting flutter/flow/layers/platform_view_layer.cc 🔶 linting flutter/flow/layers/shader_mask_layer.cc 🔶 linting flutter/flow/layers/texture_layer.cc 🔶 linting flutter/flow/layers/transform_layer.cc 🔶 linting flutter/flow/paint_region.cc 🔶 linting flutter/flow/paint_utils.cc 🔶 linting flutter/flow/raster_cache.cc 🔶 linting flutter/flow/raster_cache_key.cc 🔶 linting flutter/flow/rtree.cc 🔶 linting flutter/flow/skia_gpu_object.cc 🔶 linting flutter/flow/surface.cc 🔶 linting flutter/flow/surface_frame.cc 🔶 linting flutter/flow/testing/diff_context_test.cc 🔶 linting flutter/flow/testing/gl_context_switch_test.cc 🔶 linting flutter/flow/testing/mock_embedder.cc 🔶 linting flutter/flow/testing/mock_layer.cc 🔶 linting flutter/flow/testing/mock_raster_cache.cc 🔶 linting flutter/flow/testing/mock_texture.cc 🔶 linting flutter/flow/testing/skia_gpu_object_layer_test.cc 🔶 linting flutter/flow/embedded_view_params_unittests.cc 🔶 linting flutter/flow/flow_run_all_unittests.cc 🔶 linting flutter/flow/flow_test_utils.cc 🔶 linting flutter/flow/frame_timings_recorder_unittests.cc 🔶 linting flutter/flow/gl_context_switch_unittests.cc 🔶 linting flutter/flow/instrumentation_unittests.cc 🔶 linting flutter/flow/layers/backdrop_filter_layer_unittests.cc 🔶 linting flutter/flow/layers/checkerboard_layertree_unittests.cc 🔶 linting flutter/flow/layers/clip_path_layer_unittests.cc 🔶 linting flutter/flow/layers/clip_rect_layer_unittests.cc 🔶 linting flutter/flow/layers/clip_rrect_layer_unittests.cc 🔶 linting flutter/flow/layers/color_filter_layer_unittests.cc 🔶 linting flutter/flow/layers/container_layer_unittests.cc 🔶 linting flutter/flow/layers/display_list_layer_unittests.cc 🔶 linting flutter/flow/layers/image_filter_layer_unittests.cc 🔶 linting flutter/flow/layers/layer_tree_unittests.cc 🔶 linting flutter/flow/layers/opacity_layer_unittests.cc 🔶 linting flutter/flow/layers/performance_overlay_layer_unittests.cc 🔶 linting flutter/flow/layers/physical_shape_layer_unittests.cc 🔶 linting flutter/flow/layers/picture_layer_unittests.cc 🔶 linting flutter/flow/layers/platform_view_layer_unittests.cc 🔶 linting flutter/flow/layers/shader_mask_layer_unittests.cc 🔶 linting flutter/flow/layers/texture_layer_unittests.cc 🔶 linting flutter/flow/layers/transform_layer_unittests.cc 🔶 linting flutter/flow/mutators_stack_unittests.cc 🔶 linting flutter/flow/raster_cache_unittests.cc 🔶 linting flutter/flow/rtree_unittests.cc 🔶 linting flutter/flow/skia_gpu_object_unittests.cc 🔶 linting flutter/flow/testing/auto_save_layer_unittests.cc 🔶 linting flutter/flow/testing/mock_layer_unittests.cc 🔶 linting flutter/flow/testing/mock_texture_unittests.cc 🔶 linting flutter/flow/texture_unittests.cc 🔶 linting flutter/fml/command_line.cc 🔶 linting flutter/fml/ascii_trie.cc 🔶 linting flutter/fml/base32.cc 🔶 linting flutter/fml/concurrent_message_loop.cc 🔶 linting flutter/fml/delayed_task.cc 🔶 linting flutter/fml/endianness.cc 🔶 linting flutter/fml/file.cc 🔶 linting flutter/fml/hex_codec.cc 🔶 linting flutter/fml/icu_util.cc 🔶 linting flutter/fml/log_settings.cc 🔶 linting flutter/fml/log_settings_state.cc 🔶 linting flutter/fml/logging.cc 🔶 linting flutter/fml/mapping.cc 🔶 linting flutter/fml/memory/task_runner_checker.cc 🔶 linting flutter/fml/memory/weak_ptr_internal.cc 🔶 linting flutter/fml/message_loop.cc 🔶 linting flutter/fml/message_loop_impl.cc 🔶 linting flutter/fml/message_loop_task_queues.cc 🔶 linting flutter/fml/paths.cc 🔶 linting flutter/fml/raster_thread_merger.cc 🔶 linting flutter/fml/shared_thread_merger.cc 🔶 linting flutter/fml/synchronization/count_down_latch.cc 🔶 linting flutter/fml/synchronization/semaphore.cc 🔶 linting flutter/fml/synchronization/sync_switch.cc 🔶 linting flutter/fml/synchronization/waitable_event.cc 🔶 linting flutter/fml/task_runner.cc 🔶 linting flutter/fml/task_source.cc 🔶 linting flutter/fml/thread.cc 🔶 linting flutter/fml/thread_local.cc 🔶 linting flutter/fml/time/dart_timestamp_provider.cc 🔶 linting flutter/fml/time/time_point.cc 🔶 linting flutter/fml/trace_event.cc 🔶 linting flutter/fml/unique_fd.cc 🔶 linting flutter/fml/backtrace.cc 🔶 linting flutter/fml/platform/posix/shared_mutex_posix.cc 🔶 linting flutter/fml/platform/darwin/cf_utils.cc 🔶 linting flutter/fml/platform/darwin/message_loop_darwin.mm 🔶 linting flutter/fml/platform/darwin/paths_darwin.mm 🔶 linting flutter/fml/platform/darwin/platform_version.mm 🔶 linting flutter/fml/platform/darwin/scoped_block.mm 🔶 linting flutter/fml/platform/darwin/scoped_nsobject.mm 🔶 linting flutter/fml/platform/darwin/string_range_sanitization.mm 🔶 linting flutter/fml/platform/posix/file_posix.cc 🔶 linting flutter/fml/platform/posix/mapping_posix.cc 🔶 linting flutter/fml/platform/posix/native_library_posix.cc 🔶 linting flutter/fml/platform/posix/paths_posix.cc 🔶 linting flutter/fml/platform/posix/posix_wrappers_posix.cc 🔶 linting flutter/fml/message_loop_task_queues_benchmark.cc 🔶 linting flutter/fml/ascii_trie_unittests.cc 🔶 linting flutter/fml/backtrace_unittests.cc 🔶 linting flutter/fml/base32_unittest.cc 🔶 linting flutter/fml/command_line_unittest.cc 🔶 linting flutter/fml/endianness_unittests.cc 🔶 linting flutter/fml/file_unittest.cc 🔶 linting flutter/fml/hash_combine_unittests.cc 🔶 linting flutter/fml/hex_codec_unittest.cc 🔶 linting flutter/fml/logging_unittests.cc 🔶 linting flutter/fml/mapping_unittests.cc 🔶 linting flutter/fml/math_unittests.cc 🔶 linting flutter/fml/memory/ref_counted_unittest.cc 🔶 linting flutter/fml/memory/task_runner_checker_unittest.cc 🔶 linting flutter/fml/memory/weak_ptr_unittest.cc 🔶 linting flutter/fml/message_loop_impl_unittests.cc 🔶 linting flutter/fml/message_loop_task_queues_merge_unmerge_unittests.cc 🔶 linting flutter/fml/message_loop_task_queues_unittests.cc 🔶 linting flutter/fml/message_loop_unittests.cc 🔶 linting flutter/fml/paths_unittests.cc 🔶 linting flutter/fml/raster_thread_merger_unittests.cc 🔶 linting flutter/fml/synchronization/count_down_latch_unittests.cc 🔶 linting flutter/fml/synchronization/semaphore_unittest.cc 🔶 linting flutter/fml/synchronization/sync_switch_unittest.cc 🔶 linting flutter/fml/synchronization/waitable_event_unittest.cc 🔶 linting flutter/fml/task_source_unittests.cc 🔶 linting flutter/fml/thread_local_unittests.cc 🔶 linting flutter/fml/thread_unittests.cc 🔶 linting flutter/fml/time/chrono_timestamp_provider.cc 🔶 linting flutter/fml/time/time_delta_unittest.cc 🔶 linting flutter/fml/time/time_point_unittest.cc 🔶 linting flutter/fml/time/time_unittest.cc 🔶 linting flutter/fml/platform/darwin/cf_utils_unittests.mm 🔶 linting flutter/fml/platform/darwin/string_range_sanitization_unittests.mm 🔶 linting flutter/fml/dart/dart_converter.cc 🔶 linting flutter/impeller/aiks/aiks_context.cc 🔶 linting flutter/impeller/aiks/canvas.cc 🔶 linting flutter/impeller/aiks/image.cc 🔶 linting flutter/impeller/aiks/paint.cc 🔶 linting flutter/impeller/aiks/paint_pass_delegate.cc 🔶 linting flutter/impeller/aiks/picture.cc 🔶 linting flutter/impeller/aiks/picture_recorder.cc 🔶 linting flutter/impeller/aiks/aiks_playground.cc 🔶 linting flutter/impeller/aiks/aiks_unittests.cc 🔶 linting flutter/impeller/archivist/archivable.cc 🔶 linting flutter/impeller/archivist/archive.cc 🔶 linting flutter/impeller/archivist/archive_class_registration.cc 🔶 linting flutter/impeller/archivist/archive_database.cc 🔶 linting flutter/impeller/archivist/archive_location.cc 🔶 linting flutter/impeller/archivist/archive_statement.cc 🔶 linting flutter/impeller/archivist/archive_transaction.cc 🔶 linting flutter/impeller/archivist/archive_vector.cc 🔶 linting flutter/impeller/archivist/archivist_fixture.cc 🔶 linting flutter/impeller/archivist/archivist_unittests.cc 🔶 linting flutter/impeller/base/allocation.cc 🔶 linting flutter/impeller/base/promise.cc 🔶 linting flutter/impeller/base/strings.cc 🔶 linting flutter/impeller/base/validation.cc 🔶 linting flutter/impeller/compiler/compiler.cc 🔶 linting flutter/impeller/compiler/reflector.cc 🔶 linting flutter/impeller/compiler/switches.cc 🔶 linting flutter/impeller/compiler/utilities.cc 🔶 linting flutter/impeller/compiler/compiler_unittests.cc 🔶 linting flutter/impeller/compiler/impellerc_main.cc 🔶 linting flutter/impeller/display_list/display_list_dispatcher.cc 🔶 linting flutter/impeller/display_list/display_list_unittests.cc 🔶 linting flutter/impeller/entity/content_context.cc 🔶 linting flutter/impeller/entity/contents.cc 🔶 linting flutter/impeller/entity/entity.cc 🔶 linting flutter/impeller/entity/entity_pass.cc 🔶 linting flutter/impeller/entity/entity_pass_delegate.cc 🔶 linting flutter/impeller/entity/entity_playground.cc 🔶 linting flutter/impeller/entity/entity_unittests.cc 🔶 linting flutter/impeller/geometry/color.cc 🔶 linting flutter/impeller/geometry/matrix.cc 🔶 linting flutter/impeller/geometry/matrix_decomposition.cc 🔶 linting flutter/impeller/geometry/path.cc 🔶 linting flutter/impeller/geometry/path_builder.cc 🔶 linting flutter/impeller/geometry/path_component.cc 🔶 linting flutter/impeller/geometry/point.cc 🔶 linting flutter/impeller/geometry/quaternion.cc 🔶 linting flutter/impeller/geometry/rect.cc 🔶 linting flutter/impeller/geometry/shear.cc 🔶 linting flutter/impeller/geometry/size.cc 🔶 linting flutter/impeller/geometry/vector.cc 🔶 linting flutter/impeller/geometry/geometry_unittests.cc 🔶 linting flutter/impeller/image/compressed_image.cc 🔶 linting flutter/impeller/image/decompressed_image.cc 🔶 linting flutter/impeller/playground/playground.mm 🔶 linting flutter/impeller/renderer/allocator.cc 🔶 linting flutter/impeller/renderer/buffer.cc 🔶 linting flutter/impeller/renderer/buffer_view.cc 🔶 linting flutter/impeller/renderer/command.cc 🔶 linting flutter/impeller/renderer/command_buffer.cc 🔶 linting flutter/impeller/renderer/comparable.cc 🔶 linting flutter/impeller/renderer/context.cc 🔶 linting flutter/impeller/renderer/device_buffer.cc 🔶 linting flutter/impeller/renderer/formats.cc 🔶 linting flutter/impeller/renderer/host_buffer.cc 🔶 linting flutter/impeller/renderer/pipeline.cc 🔶 linting flutter/impeller/renderer/pipeline_builder.cc 🔶 linting flutter/impeller/renderer/pipeline_descriptor.cc 🔶 linting flutter/impeller/renderer/pipeline_library.cc 🔶 linting flutter/impeller/renderer/platform.cc 🔶 linting flutter/impeller/renderer/range.cc 🔶 linting flutter/impeller/renderer/render_pass.cc 🔶 linting flutter/impeller/renderer/render_target.cc 🔶 linting flutter/impeller/renderer/renderer.cc 🔶 linting flutter/impeller/renderer/sampler.cc 🔶 linting flutter/impeller/renderer/sampler_descriptor.cc 🔶 linting flutter/impeller/renderer/sampler_library.cc 🔶 linting flutter/impeller/renderer/shader_function.cc 🔶 linting flutter/impeller/renderer/shader_library.cc 🔶 linting flutter/impeller/renderer/shader_types.cc 🔶 linting flutter/impeller/renderer/surface.cc 🔶 linting flutter/impeller/renderer/tessellator.cc 🔶 linting flutter/impeller/renderer/texture.cc 🔶 linting flutter/impeller/renderer/texture_descriptor.cc 🔶 linting flutter/impeller/renderer/vertex_buffer.cc 🔶 linting flutter/impeller/renderer/vertex_buffer_builder.cc 🔶 linting flutter/impeller/renderer/vertex_descriptor.cc 🔶 linting flutter/impeller/renderer/backend/metal/allocator_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/command_buffer_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/context_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/device_buffer_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/formats_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/pipeline_library_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/pipeline_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/render_pass_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/sampler_library_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/sampler_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/shader_function_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/shader_library_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/surface_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/texture_mtl.mm 🔶 linting flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm 🔶 linting flutter/impeller/renderer/device_buffer_unittests.cc 🔶 linting flutter/impeller/renderer/host_buffer_unittests.cc 🔶 linting flutter/impeller/renderer/renderer_unittests.cc 🔶 linting flutter/lib/io/dart_io.cc 🔶 linting flutter/lib/spirv/test/glsl_to_spirv.cc 🔶 linting flutter/lib/spirv/test/spirv_assembler.cc 🔶 linting flutter/lib/ui/compositing/scene.cc 🔶 linting flutter/lib/ui/compositing/scene_builder.cc 🔶 linting flutter/lib/ui/dart_runtime_hooks.cc 🔶 linting flutter/lib/ui/dart_ui.cc 🔶 linting flutter/lib/ui/isolate_name_server/isolate_name_server.cc 🔶 linting flutter/lib/ui/isolate_name_server/isolate_name_server_natives.cc 🔶 linting flutter/lib/ui/painting/canvas.cc 🔶 linting flutter/lib/ui/painting/codec.cc 🔶 linting flutter/lib/ui/painting/color_filter.cc 🔶 linting flutter/lib/ui/painting/engine_layer.cc 🔶 linting flutter/lib/ui/painting/fragment_program.cc 🔶 linting flutter/lib/ui/painting/fragment_shader.cc 🔶 linting flutter/lib/ui/painting/gradient.cc 🔶 linting flutter/lib/ui/painting/image.cc 🔶 linting flutter/lib/ui/painting/image_decoder.cc 🔶 linting flutter/lib/ui/painting/image_descriptor.cc 🔶 linting flutter/lib/ui/painting/image_encoding.cc 🔶 linting flutter/lib/ui/painting/image_filter.cc 🔶 linting flutter/lib/ui/painting/image_generator.cc 🔶 linting flutter/lib/ui/painting/image_generator_registry.cc 🔶 linting flutter/lib/ui/painting/image_shader.cc 🔶 linting flutter/lib/ui/painting/immutable_buffer.cc 🔶 linting flutter/lib/ui/painting/matrix.cc 🔶 linting flutter/lib/ui/painting/multi_frame_codec.cc 🔶 linting flutter/lib/ui/painting/paint.cc 🔶 linting flutter/lib/ui/painting/path.cc 🔶 linting flutter/lib/ui/painting/path_measure.cc 🔶 linting flutter/lib/ui/painting/picture.cc 🔶 linting flutter/lib/ui/painting/picture_recorder.cc 🔶 linting flutter/lib/ui/painting/rrect.cc 🔶 linting flutter/lib/ui/painting/shader.cc 🔶 linting flutter/lib/ui/painting/single_frame_codec.cc 🔶 linting flutter/lib/ui/painting/vertices.cc 🔶 linting flutter/lib/ui/plugins/callback_cache.cc 🔶 linting flutter/lib/ui/semantics/custom_accessibility_action.cc 🔶 linting flutter/lib/ui/semantics/semantics_node.cc 🔶 linting flutter/lib/ui/semantics/semantics_update.cc 🔶 linting flutter/lib/ui/semantics/semantics_update_builder.cc 🔶 linting flutter/lib/ui/semantics/string_attribute.cc 🔶 linting flutter/lib/ui/text/asset_manager_font_provider.cc 🔶 linting flutter/lib/ui/text/font_collection.cc 🔶 linting flutter/lib/ui/text/paragraph.cc 🔶 linting flutter/lib/ui/text/paragraph_builder.cc 🔶 linting flutter/lib/ui/ui_dart_state.cc 🔶 linting flutter/lib/ui/volatile_path_tracker.cc 🔶 linting flutter/lib/ui/window/key_data.cc 🔶 linting flutter/lib/ui/window/key_data_packet.cc 🔶 linting flutter/lib/ui/window/platform_configuration.cc 🔶 linting flutter/lib/ui/window/platform_message.cc 🔶 linting flutter/lib/ui/window/platform_message_response.cc 🔶 linting flutter/lib/ui/window/platform_message_response_dart.cc 🔶 linting flutter/lib/ui/window/pointer_data.cc 🔶 linting flutter/lib/ui/window/pointer_data_packet.cc 🔶 linting flutter/lib/ui/window/pointer_data_packet_converter.cc 🔶 linting flutter/lib/ui/window/viewport_metrics.cc 🔶 linting flutter/lib/ui/window/window.cc 🔶 linting flutter/lib/ui/ui_benchmarks.cc 🔶 linting flutter/lib/ui/compositing/scene_builder_unittests.cc 🔶 linting flutter/lib/ui/hooks_unittests.cc 🔶 linting flutter/lib/ui/painting/image_dispose_unittests.cc 🔶 linting flutter/lib/ui/painting/image_encoding_unittests.cc 🔶 linting flutter/lib/ui/painting/image_generator_registry_unittests.cc 🔶 linting flutter/lib/ui/painting/path_unittests.cc 🔶 linting flutter/lib/ui/painting/single_frame_codec_unittests.cc 🔶 linting flutter/lib/ui/painting/vertices_unittests.cc 🔶 linting flutter/lib/ui/semantics/semantics_update_builder_unittests.cc 🔶 linting flutter/lib/ui/window/platform_configuration_unittests.cc 🔶 linting flutter/lib/ui/window/pointer_data_packet_converter_unittests.cc 🔶 linting flutter/lib/ui/painting/image_decoder_unittests.cc 🔶 linting flutter/runtime/no_dart_plugin_registrant_unittests.cc 🔶 linting flutter/runtime/dart_isolate.cc 🔶 linting flutter/runtime/dart_isolate_group_data.cc 🔶 linting flutter/runtime/dart_service_isolate.cc 🔶 linting flutter/runtime/dart_snapshot.cc 🔶 linting flutter/runtime/dart_vm.cc 🔶 linting flutter/runtime/dart_vm_data.cc 🔶 linting flutter/runtime/dart_vm_initializer.cc 🔶 linting flutter/runtime/dart_vm_lifecycle.cc 🔶 linting flutter/runtime/embedder_resources.cc 🔶 linting flutter/runtime/isolate_configuration.cc 🔶 linting flutter/runtime/platform_data.cc 🔶 linting flutter/runtime/runtime_controller.cc 🔶 linting flutter/runtime/runtime_delegate.cc 🔶 linting flutter/runtime/service_protocol.cc 🔶 linting flutter/runtime/skia_concurrent_executor.cc 🔶 linting flutter/runtime/dart_isolate_unittests.cc 🔶 linting flutter/runtime/dart_lifecycle_unittests.cc 🔶 linting flutter/runtime/dart_service_isolate_unittests.cc 🔶 linting flutter/runtime/dart_vm_unittests.cc 🔶 linting flutter/runtime/type_conversions_unittests.cc 🔶 linting flutter/runtime/test_font_data.cc 🔶 linting flutter/shell/common/animator.cc 🔶 linting flutter/shell/common/canvas_spy.cc 🔶 linting flutter/shell/common/context_options.cc 🔶 linting flutter/shell/common/display.cc 🔶 linting flutter/shell/common/display_manager.cc 🔶 linting flutter/shell/common/engine.cc 🔶 linting flutter/shell/common/pipeline.cc 🔶 linting flutter/shell/common/platform_view.cc 🔶 linting flutter/shell/common/pointer_data_dispatcher.cc 🔶 linting flutter/shell/common/rasterizer.cc 🔶 linting flutter/shell/common/run_configuration.cc 🔶 linting flutter/shell/common/serialization_callbacks.cc 🔶 linting flutter/shell/common/shell.cc 🔶 linting flutter/shell/common/shell_io_manager.cc 🔶 linting flutter/shell/common/skia_event_tracer_impl.cc 🔶 linting flutter/shell/common/switches.cc 🔶 linting flutter/shell/common/thread_host.cc 🔶 linting flutter/shell/common/variable_refresh_rate_display.cc 🔶 linting flutter/shell/common/vsync_waiter.cc 🔶 linting flutter/shell/common/vsync_waiter_fallback.cc 🔶 linting flutter/shell/common/dart_native_benchmarks.cc 🔶 linting flutter/shell/common/shell_benchmarks.cc 🔶 linting flutter/shell/common/shell_test.cc 🔶 linting flutter/shell/common/shell_test_external_view_embedder.cc 🔶 linting flutter/shell/common/shell_test_platform_view.cc 🔶 linting flutter/shell/common/vsync_waiters_test.cc 🔶 linting flutter/shell/common/shell_test_platform_view_gl.cc 🔶 linting flutter/shell/common/shell_test_platform_view_vulkan.cc 🔶 linting flutter/shell/common/shell_test_platform_view_metal.mm 🔶 linting flutter/shell/common/animator_unittests.cc 🔶 linting flutter/shell/common/canvas_spy_unittests.cc 🔶 linting flutter/shell/common/engine_unittests.cc 🔶 linting flutter/shell/common/input_events_unittests.cc 🔶 linting flutter/shell/common/persistent_cache_unittests.cc 🔶 linting flutter/shell/common/pipeline_unittests.cc 🔶 linting flutter/shell/common/rasterizer_unittests.cc 🔶 linting flutter/shell/common/shell_unittests.cc 🔶 linting flutter/shell/common/skp_shader_warmup_unittests.cc 🔶 linting flutter/shell/common/switches_unittests.cc 🔶 linting flutter/shell/common/variable_refresh_rate_display_unittests.cc 🔶 linting flutter/shell/gpu/gpu_surface_gl.cc 🔶 linting flutter/shell/gpu/gpu_surface_gl_delegate.cc 🔶 linting flutter/shell/gpu/gpu_surface_metal.mm 🔶 linting flutter/shell/gpu/gpu_surface_metal_delegate.cc 🔶 linting flutter/shell/gpu/gpu_surface_software.cc 🔶 linting flutter/shell/gpu/gpu_surface_software_delegate.cc 🔶 linting flutter/shell/gpu/gpu_surface_vulkan.cc 🔶 linting flutter/shell/gpu/gpu_surface_vulkan_delegate.cc 🔶 linting flutter/shell/platform/android/context/android_context.cc 🔶 linting flutter/shell/platform/android/external_view_embedder/external_view_embedder_unittests.cc 🔶 linting flutter/shell/platform/android/external_view_embedder/surface_pool_unittests.cc 🔶 linting flutter/shell/platform/android/external_view_embedder/external_view_embedder.cc 🔶 linting flutter/shell/platform/android/external_view_embedder/surface_pool.cc 🔶 linting flutter/shell/platform/android/jni/platform_view_android_jni.cc 🔶 linting flutter/shell/platform/android/jni/jni_mock_unittest.cc 🔶 linting flutter/shell/platform/android/platform_view_android_delegate/platform_view_android_delegate.cc 🔶 linting flutter/shell/platform/android/platform_view_android_delegate/platform_view_android_delegate_unittests.cc 🔶 linting flutter/shell/platform/android/surface/android_native_window.cc 🔶 linting flutter/shell/platform/android/surface/android_surface.cc 🔶 linting flutter/shell/platform/android/surface/snapshot_surface_producer.cc 🔶 linting flutter/shell/platform/android/surface/android_surface_mock.cc 🔶 linting flutter/shell/platform/common/incoming_message_dispatcher.cc 🔶 linting flutter/shell/platform/common/json_message_codec.cc 🔶 linting flutter/shell/platform/common/json_method_codec.cc 🔶 linting flutter/shell/platform/common/accessibility_bridge.cc 🔶 linting flutter/shell/platform/common/flutter_platform_node_delegate.cc 🔶 linting flutter/shell/platform/common/path_utils.cc 🔶 linting flutter/shell/platform/common/path_utils_unittests.cc 🔶 linting flutter/shell/platform/common/text_editing_delta.cc 🔶 linting flutter/shell/platform/common/text_input_model.cc 🔶 linting flutter/shell/platform/common/engine_switches.cc 🔶 linting flutter/shell/platform/common/engine_switches_unittests.cc 🔶 linting flutter/shell/platform/common/geometry_unittests.cc 🔶 linting flutter/shell/platform/common/json_message_codec_unittests.cc 🔶 linting flutter/shell/platform/common/json_method_codec_unittests.cc 🔶 linting flutter/shell/platform/common/text_editing_delta_unittests.cc 🔶 linting flutter/shell/platform/common/text_input_model_unittests.cc 🔶 linting flutter/shell/platform/common/text_range_unittests.cc 🔶 linting flutter/shell/platform/common/accessibility_bridge_unittests.cc 🔶 linting flutter/shell/platform/common/flutter_platform_node_delegate_unittests.cc 🔶 linting flutter/shell/platform/common/test_accessibility_bridge.cc 🔶 linting flutter/shell/platform/common/client_wrapper/core_implementations.cc 🔶 linting flutter/shell/platform/common/client_wrapper/plugin_registrar.cc 🔶 linting flutter/shell/platform/common/client_wrapper/standard_codec.cc 🔶 linting flutter/shell/platform/common/client_wrapper/testing/stub_flutter_api.cc 🔶 linting flutter/shell/platform/common/client_wrapper/basic_message_channel_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/encodable_value_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/event_channel_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/method_call_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/method_channel_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/method_result_functions_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/plugin_registrar_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/standard_message_codec_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/standard_method_codec_unittests.cc 🔶 linting flutter/shell/platform/common/client_wrapper/testing/test_codec_extensions.cc 🔶 linting flutter/shell/platform/common/client_wrapper/texture_registrar_unittests.cc 🔶 linting flutter/shell/platform/darwin/common/buffer_conversions.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterChannels.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodec.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/flutter_codecs_unittest.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterChannels.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm 🔶 linting flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodec.mm 🔶 linting flutter/shell/platform/darwin/graphics/FlutterDarwinContextMetal.mm 🔶 linting flutter/shell/platform/darwin/graphics/FlutterDarwinExternalTextureMetal.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/AccessibilityBridgeMacDelegateTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderExternalTextureUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTestUtils.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterFrameBufferProviderUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterGLCompositorUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManagerUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMetalCompositorUnittests.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMetalRendererTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMetalSurfaceManagerTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformViewControllerTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputSemanticsObjectTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterViewControllerTest.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterViewControllerTestUtils.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/TestFlutterPlatformView.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/AccessibilityBridgeMacDelegate.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterAppDelegate.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterBackingStore.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterBackingStoreData.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterDartProject.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterExternalTextureGL.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterExternalTextureMetal.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterFrameBufferProvider.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterGLCompositor.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceHolder.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManager.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMetalCompositor.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMetalRenderer.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterMouseCursorPlugin.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRenderer.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMac.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterRenderingBackend.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterResizableBackingStoreProvider.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterResizeSynchronizer.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputSemanticsObject.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterTextureRegistrar.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterView.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/KeyCodeMap.mm 🔶 linting flutter/shell/platform/darwin/macos/framework/Source/MacOSGLContextSwitch.mm 🔶 linting flutter/shell/platform/embedder/embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_engine.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_resolver.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_view.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_view_embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_include.c 🔶 linting flutter/shell/platform/embedder/embedder_include2.c 🔶 linting flutter/shell/platform/embedder/embedder_layers.cc 🔶 linting flutter/shell/platform/embedder/embedder_platform_message_response.cc 🔶 linting flutter/shell/platform/embedder/embedder_render_target.cc 🔶 linting flutter/shell/platform/embedder/embedder_render_target_cache.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface_software.cc 🔶 linting flutter/shell/platform/embedder/embedder_task_runner.cc 🔶 linting flutter/shell/platform/embedder/embedder_thread_host.cc 🔶 linting flutter/shell/platform/embedder/platform_view_embedder.cc 🔶 linting flutter/shell/platform/embedder/vsync_waiter_embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_gl.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface_gl.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_metal.mm 🔶 linting flutter/shell/platform/embedder/embedder_surface_metal.mm 🔶 linting flutter/shell/platform/embedder/embedder_surface_vulkan.cc 🔶 linting flutter/shell/platform/embedder/embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_engine.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_resolver.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_view.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_view_embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_include.c 🔶 linting flutter/shell/platform/embedder/embedder_include2.c 🔶 linting flutter/shell/platform/embedder/embedder_layers.cc 🔶 linting flutter/shell/platform/embedder/embedder_platform_message_response.cc 🔶 linting flutter/shell/platform/embedder/embedder_render_target.cc 🔶 linting flutter/shell/platform/embedder/embedder_render_target_cache.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface_software.cc 🔶 linting flutter/shell/platform/embedder/embedder_task_runner.cc 🔶 linting flutter/shell/platform/embedder/embedder_thread_host.cc 🔶 linting flutter/shell/platform/embedder/platform_view_embedder.cc 🔶 linting flutter/shell/platform/embedder/vsync_waiter_embedder.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_gl.cc 🔶 linting flutter/shell/platform/embedder/embedder_surface_gl.cc 🔶 linting flutter/shell/platform/embedder/embedder_external_texture_metal.mm 🔶 linting flutter/shell/platform/embedder/embedder_surface_metal.mm 🔶 linting flutter/shell/platform/embedder/embedder_surface_vulkan.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_unittests_proctable.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_a11y_unittests.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_config_builder.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_backingstore_producer.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_compositor.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_compositor_software.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_context.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_context_software.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_unittests.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_unittests_util.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_compositor_gl.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_context_gl.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_unittests_gl.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_compositor_metal.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_context_metal.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_compositor_vulkan.cc 🔶 linting flutter/shell/platform/embedder/tests/embedder_test_context_vulkan.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/flutter_engine.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/flutter_window_controller.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/flutter_engine_unittests.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/flutter_window_controller_unittests.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/flutter_window_unittests.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/plugin_registrar_glfw_unittests.cc 🔶 linting flutter/shell/platform/glfw/client_wrapper/testing/stub_flutter_glfw_api.cc 🔶 linting flutter/shell/profiling/sampling_profiler.cc 🔶 linting flutter/shell/profiling/sampling_profiler_unittest.cc 🔶 linting flutter/shell/testing/tester_main.cc 🔷 ignoring flutter/shell/version/version.cc (FLUTTER_NOLINT) 🔶 linting flutter/testing/dart_isolate_runner.cc 🔶 linting flutter/testing/elf_loader.cc 🔶 linting flutter/testing/test_dart_native_resolver.cc 🔶 linting flutter/testing/dart_fixture.cc 🔶 linting flutter/testing/fixture_test.cc 🔶 linting flutter/testing/test_metal_context.mm 🔶 linting flutter/testing/test_metal_surface.cc 🔶 linting flutter/testing/test_metal_surface_impl.mm 🔶 linting flutter/testing/test_gl_surface.cc 🔶 linting flutter/testing/assertions_skia.cc 🔶 linting flutter/testing/mock_canvas.cc 🔶 linting flutter/testing/debugger_detection.cc 🔶 linting flutter/testing/run_all_unittests.cc 🔶 linting flutter/testing/test_timeout_listener.cc 🔶 linting flutter/testing/post_task_sync.cc 🔶 linting flutter/testing/testing.cc 🔶 linting flutter/testing/thread_test.cc 🔶 linting flutter/testing/mock_canvas_unittests.cc 🔶 linting flutter/testing/test_metal_surface_unittests.cc 🔶 linting flutter/testing/test_vulkan_context.cc 🔶 linting flutter/testing/test_vulkan_image.cc 🔶 linting flutter/testing/test_vulkan_surface.cc 🔶 linting flutter/tools/font-subset/main.cc 🔶 linting flutter/vulkan/vulkan_application.cc 🔶 linting flutter/vulkan/vulkan_backbuffer.cc 🔶 linting flutter/vulkan/vulkan_command_buffer.cc 🔶 linting flutter/vulkan/vulkan_debug_report.cc 🔶 linting flutter/vulkan/vulkan_device.cc 🔶 linting flutter/vulkan/vulkan_handle.cc 🔶 linting flutter/vulkan/vulkan_image.cc 🔶 linting flutter/vulkan/vulkan_interface.cc 🔶 linting flutter/vulkan/vulkan_native_surface.cc 🔶 linting flutter/vulkan/vulkan_proc_table.cc 🔶 linting flutter/vulkan/vulkan_surface.cc 🔶 linting flutter/vulkan/vulkan_utilities.cc 🔷 ignoring flutter/vulkan/vulkan_window.cc (FLUTTER_NOLINT) 🔶 linting flutter/vulkan/vulkan_swapchain_stub.cc ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc: /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:34:57: error: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors] TimeDelta::FromMilliseconds(static_cast(rand()) % 20u); ^~~~ /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:34:57: note: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead TimeDelta::FromMilliseconds(static_cast(rand()) % 20u); ^~~~ /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:76:13: error: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors] if (rand() % 2 == 0) { ^~~~ /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:76:13: note: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead if (rand() % 2 == 0) { ^~~~ /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:161:15: error: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors] if (rand() % 2 == 0) { ^~~~ /Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:161:15: note: Function 'rand' is obsolete because it implements a poor random number generator. Use 'arc4random' instead if (rand() % 2 == 0) { ^~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/aiks/aiks_context.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/aiks/aiks_playground.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/entity/content_context.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/entity/contents.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/entity/entity.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/entity/entity_pass.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/entity/entity_playground.cc: /Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/gradient_fill.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/playground/playground.mm: /Users/m/Projects/engine/src/flutter/impeller/playground/playground.mm:8:10: error: 'flutter/impeller/entity/entity_shaders.h' file not found [clang-diagnostic-error] #include "flutter/impeller/entity/entity_shaders.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/impeller/renderer/renderer_unittests.cc: /Users/m/Projects/engine/src/flutter/impeller/renderer/renderer_unittests.cc:6:10: error: 'flutter/impeller/fixtures/box_fade.frag.h' file not found [clang-diagnostic-error] #include "flutter/impeller/fixtures/box_fade.frag.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm: /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:63:1: error: Address of stack memory associated with local variable 'called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:63:1: error: Address of stack memory associated with local variable 'flutterTexture' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:85:1: error: Address of stack memory associated with local variable 'called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:85:1: error: Address of stack memory associated with local variable 'registeredTextureId' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:107:1: error: Address of stack memory associated with local variable 'called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterOpenGLRendererTest.mm:107:1: error: Address of stack memory associated with local variable 'registeredTextureId' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm: /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:176:7: error: Potential leak of memory pointed to by 'keyLabel' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors] if (character != 0) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:519:3: note: Taking false branch NSAssert(callback != nil, @"The callback must not be nil."); ^ /Users/m/Applications/Xcode-13-2-1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSException.h:106:2: note: expanded from macro 'NSAssert' if (__builtin_expect(!(condition), 0)) { \ ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:519:3: note: Loop condition is false. Exiting loop NSAssert(callback != nil, @"The callback must not be nil."); ^ /Users/m/Applications/Xcode-13-2-1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSException.h:104:5: note: expanded from macro 'NSAssert' do { \ ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:522:3: note: Control jumps to 'case NSEventTypeKeyDown:' at line 523 switch (event.type) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:524:7: note: Calling 'handleDownEvent:callback:' [self handleDownEvent:event callback:guardedCallback]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:674:25: note: Calling 'GetLogicalKeyForEvent' uint64_t logicalKey = GetLogicalKeyForEvent(event, physicalKey); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:150:7: note: Assuming the condition is false if (fromKeyCode != nil) { ^~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:150:3: note: Taking false branch if (fromKeyCode != nil) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:164:7: note: Assuming the condition is true if (keyLabelUtf16.length != 0) { ^~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:164:3: note: Taking true branch if (keyLabelUtf16.length != 0) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:166:26: note: Calling 'DecodeUtf16' uint32_t* keyLabel = DecodeUtf16(keyLabelUtf16, &keyLabelLength); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:120:22: note: Memory is allocated uint32_t* result = new uint32_t[target.length]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:122:35: note: Assuming the condition is false for (NSUInteger target_pos = 0; target_pos < target.length; target_pos += 1) { ^~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:122:3: note: Loop condition is false. Execution continues on line 138 for (NSUInteger target_pos = 0; target_pos < target.length; target_pos += 1) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:166:26: note: Returned allocated memory uint32_t* keyLabel = DecodeUtf16(keyLabelUtf16, &keyLabelLength); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:167:9: note: 'keyLabelLength' is not equal to 1 if (keyLabelLength == 1) { ^~~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:167:5: note: Taking false branch if (keyLabelLength == 1) { ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm:176:7: note: Potential leak of memory pointed to by 'keyLabel' if (character != 0) { ^ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm: /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:212:1: error: Address of stack memory associated with local variable 'called_action' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:212:1: error: Address of stack memory associated with local variable 'called_id' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:223:34: error: User-facing text should use localized string macro [clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,-warnings-as-errors] viewController.textInputPlugin.string = @"textfield"; ^ ~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:223:43: note: Non-localized string literal here viewController.textInputPlugin.string = @"textfield"; ^~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:223:34: note: User-facing text should use localized string macro viewController.textInputPlugin.string = @"textfield"; ^ ~~~~~~~~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:294:2: warning: namespace 'flutter::testing' ends with an unrecognized comment [google-readability-namespace-comments] } // flutter::testing ^~~~~~~~~~~~~~~~~~~~~ // namespace flutter::testing /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterPlatformNodeDelegateMacTest.mm:19:11: note: namespace 'flutter::testing' starts here namespace flutter::testing { ^ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm: /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:56:1: error: Address of stack memory associated with local variable 'called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:156:1: error: Address of stack memory associated with local variable 'enabled_called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:156:1: error: Address of stack memory associated with local variable 'semanticsEnabled' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:238:1: error: Address of stack memory associated with local variable 'enabled_called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:238:1: error: Address of stack memory associated with local variable 'semanticsEnabled' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:328:1: error: Address of stack memory associated with local variable 'enabled_called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:343:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(latch_called); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:343:3: error: Address of stack memory associated with local variable 'latch_called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(latch_called); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:344:1: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:344:1: error: Address of stack memory associated with local variable 'latch_called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:346:1: warning: missing username/bug in TODO [google-readability-todo] // TODO: Enable after https://github.com/flutter/flutter/issues/96668 is fixed. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ // TODO(m): Enable after https://github.com/flutter/flutter/issues/96668 is fixed. /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:412:1: error: Address of stack memory associated with local variable 'called' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm:412:1: error: Address of stack memory associated with local variable 'original_init' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm: /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm:34:5: error: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy,-warnings-as-errors] strcpy(character, event->character); ^~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm:34:5: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 strcpy(character, event->character); ^~~~~~ /Users/m/Projects/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm:73:1: warning: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace] using namespace ::flutter::testing::keycodes; ^ ❌ Failures for clang-tidy on /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm: /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:197:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2080:32: note: expanded from macro 'ASSERT_EQ' # define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2064:3: note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:167:44: note: expanded from macro 'ASSERT_PRED_FORMAT2' GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:149:17: note: expanded from macro 'GTEST_PRED_FORMAT2_' on_failure) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:79:5: note: expanded from macro 'GTEST_ASSERT_' on_failure(gtest_ar.failure_message()) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:198:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(engine.is_valid()); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:201:1: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:374:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2080:32: note: expanded from macro 'ASSERT_EQ' # define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2064:3: note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:167:44: note: expanded from macro 'ASSERT_PRED_FORMAT2' GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:149:17: note: expanded from macro 'GTEST_PRED_FORMAT2_' on_failure) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:79:5: note: expanded from macro 'GTEST_ASSERT_' on_failure(gtest_ar.failure_message()) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:375:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(engine.is_valid()); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:379:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(ImageMatchesFixture("compositor.png", scene_image)); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:380:1: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:432:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2080:32: note: expanded from macro 'ASSERT_EQ' # define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:2064:3: note: expanded from macro 'GTEST_ASSERT_EQ' ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:167:44: note: expanded from macro 'ASSERT_PRED_FORMAT2' GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:149:17: note: expanded from macro 'GTEST_PRED_FORMAT2_' on_failure) ^ ../../third_party/googletest/googletest/include/gtest/gtest_pred_impl.h:79:5: note: expanded from macro 'GTEST_ASSERT_' on_failure(gtest_ar.failure_message()) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:433:3: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] ASSERT_TRUE(engine.is_valid()); ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1997:32: note: expanded from macro 'ASSERT_TRUE' #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition) ^ ../../third_party/googletest/googletest/include/gtest/gtest.h:1980:23: note: expanded from macro 'GTEST_ASSERT_TRUE' GTEST_FATAL_FAILURE_) ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1503:5: note: expanded from macro 'GTEST_TEST_BOOLEAN_' fail(::testing::internal::GetBoolAssertionFailureMessage(\ ^ ../../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1344:3: note: expanded from macro 'GTEST_FATAL_FAILURE_' return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure) ^ /Users/m/Projects/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests_metal.mm:435:1: error: Address of stack memory associated with local variable 'latch' is still referred to by the static variable 'closure' upon returning to the caller. This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors] } ^ Jobs: 100% done, 625/641 completed, 0 in progress, 0 pending, 16 failed. Lint problems found.