Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ff04b8f

Browse files
[CP] Revert "[Android] Return keyboard pressed state" (#42616) (#42816)
Reverts #41695 due to internal bug report b/284945818. cherry pick request was filed at b/287043578 Co-authored-by: Tong Mu <[email protected]>
1 parent 4f4486b commit ff04b8f

File tree

13 files changed

+1
-257
lines changed

13 files changed

+1
-257
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2380,7 +2380,6 @@ ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/rend
23802380
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/SurfaceTextureWrapper.java + ../../../flutter/LICENSE
23812381
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/DeferredComponentChannel.java + ../../../flutter/LICENSE
23822382
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyEventChannel.java + ../../../flutter/LICENSE
2383-
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyboardChannel.java + ../../../flutter/LICENSE
23842383
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java + ../../../flutter/LICENSE
23852384
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LocalizationChannel.java + ../../../flutter/LICENSE
23862385
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/MouseCursorChannel.java + ../../../flutter/LICENSE
@@ -2414,7 +2413,6 @@ ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/Listen
24142413
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/SpellCheckPlugin.java + ../../../flutter/LICENSE
24152414
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/TextEditingDelta.java + ../../../flutter/LICENSE
24162415
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java + ../../../flutter/LICENSE
2417-
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/keyboard/KeyboardPlugin.java + ../../../flutter/LICENSE
24182416
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/localization/LocalizationPlugin.java + ../../../flutter/LICENSE
24192417
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/mouse/MouseCursorPlugin.java + ../../../flutter/LICENSE
24202418
ORIGIN: ../../../flutter/shell/platform/android/io/flutter/plugin/platform/AccessibilityEventsDelegate.java + ../../../flutter/LICENSE
@@ -5055,7 +5053,6 @@ FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/render
50555053
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java
50565054
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/DeferredComponentChannel.java
50575055
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyEventChannel.java
5058-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyboardChannel.java
50595056
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java
50605057
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LocalizationChannel.java
50615058
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/MouseCursorChannel.java
@@ -5092,7 +5089,6 @@ FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/Listenab
50925089
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/SpellCheckPlugin.java
50935090
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/TextEditingDelta.java
50945091
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
5095-
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/keyboard/KeyboardPlugin.java
50965092
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/localization/LocalizationPlugin.java
50975093
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/mouse/MouseCursorPlugin.java
50985094
FILE: ../../../flutter/shell/platform/android/io/flutter/plugin/platform/AccessibilityEventsDelegate.java

shell/platform/android/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@ android_java_sources = [
250250
"io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java",
251251
"io/flutter/embedding/engine/systemchannels/DeferredComponentChannel.java",
252252
"io/flutter/embedding/engine/systemchannels/KeyEventChannel.java",
253-
"io/flutter/embedding/engine/systemchannels/KeyboardChannel.java",
254253
"io/flutter/embedding/engine/systemchannels/LifecycleChannel.java",
255254
"io/flutter/embedding/engine/systemchannels/LocalizationChannel.java",
256255
"io/flutter/embedding/engine/systemchannels/MouseCursorChannel.java",
@@ -287,7 +286,6 @@ android_java_sources = [
287286
"io/flutter/plugin/editing/SpellCheckPlugin.java",
288287
"io/flutter/plugin/editing/TextEditingDelta.java",
289288
"io/flutter/plugin/editing/TextInputPlugin.java",
290-
"io/flutter/plugin/keyboard/KeyboardPlugin.java",
291289
"io/flutter/plugin/localization/LocalizationPlugin.java",
292290
"io/flutter/plugin/mouse/MouseCursorPlugin.java",
293291
"io/flutter/plugin/platform/AccessibilityEventsDelegate.java",

shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
import io.flutter.plugin.common.BinaryMessenger;
6363
import io.flutter.plugin.editing.SpellCheckPlugin;
6464
import io.flutter.plugin.editing.TextInputPlugin;
65-
import io.flutter.plugin.keyboard.KeyboardPlugin;
6665
import io.flutter.plugin.localization.LocalizationPlugin;
6766
import io.flutter.plugin.mouse.MouseCursorPlugin;
6867
import io.flutter.plugin.platform.PlatformViewsController;
@@ -131,7 +130,6 @@ public class FlutterView extends FrameLayout
131130
@Nullable private MouseCursorPlugin mouseCursorPlugin;
132131
@Nullable private TextInputPlugin textInputPlugin;
133132
@Nullable private SpellCheckPlugin spellCheckPlugin;
134-
@Nullable private KeyboardPlugin keyboardPlugin;
135133
@Nullable private LocalizationPlugin localizationPlugin;
136134
@Nullable private KeyboardManager keyboardManager;
137135
@Nullable private AndroidTouchProcessor androidTouchProcessor;
@@ -1179,8 +1177,6 @@ public void attachToFlutterEngine(@NonNull FlutterEngine flutterEngine) {
11791177
localizationPlugin = this.flutterEngine.getLocalizationPlugin();
11801178

11811179
keyboardManager = new KeyboardManager(this);
1182-
keyboardPlugin = new KeyboardPlugin(keyboardManager, this.flutterEngine.getKeyboardChannel());
1183-
11841180
androidTouchProcessor =
11851181
new AndroidTouchProcessor(this.flutterEngine.getRenderer(), /*trackMotionEvents=*/ false);
11861182
accessibilityBridge =
@@ -1277,12 +1273,10 @@ public void detachFromFlutterEngine() {
12771273
if (spellCheckPlugin != null) {
12781274
spellCheckPlugin.destroy();
12791275
}
1276+
12801277
if (mouseCursorPlugin != null) {
12811278
mouseCursorPlugin.destroy();
12821279
}
1283-
if (keyboardPlugin != null) {
1284-
keyboardPlugin.destroy();
1285-
}
12861280

12871281
// Instruct our FlutterRenderer that we are no longer interested in being its RenderSurface.
12881282
FlutterRenderer flutterRenderer = flutterEngine.getRenderer();

shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
import io.flutter.embedding.android.KeyboardMap.TogglingGoal;
1212
import io.flutter.plugin.common.BinaryMessenger;
1313
import java.util.ArrayList;
14-
import java.util.Collections;
1514
import java.util.HashMap;
16-
import java.util.Map;
1715

1816
/**
1917
* A {@link KeyboardManager.Responder} of {@link KeyboardManager} that handles events by sending
@@ -407,14 +405,4 @@ public void handleEvent(
407405
onKeyEventHandledCallback.onKeyEventHandled(true);
408406
}
409407
}
410-
411-
/**
412-
* Returns an unmodifiable view of the pressed state.
413-
*
414-
* @return A map whose keys are physical keyboard key IDs and values are the corresponding logical
415-
* keyboard key IDs.
416-
*/
417-
public Map<Long, Long> getPressedState() {
418-
return Collections.unmodifiableMap(pressingRecords);
419-
}
420408
}

shell/platform/android/io/flutter/embedding/android/KeyboardManager.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.flutter.plugin.editing.InputConnectionAdaptor;
1414
import io.flutter.plugin.editing.TextInputPlugin;
1515
import java.util.HashSet;
16-
import java.util.Map;
1716

1817
/**
1918
* Processes keyboard events and cooperate with {@link TextInputPlugin}.
@@ -253,15 +252,4 @@ private void onUnhandled(@NonNull KeyEvent keyEvent) {
253252
Log.w(TAG, "A redispatched key event was consumed before reaching KeyboardManager");
254253
}
255254
}
256-
257-
/**
258-
* Returns an unmodifiable view of the pressed state.
259-
*
260-
* @return A map whose keys are physical keyboard key IDs and values are the corresponding logical
261-
* keyboard key IDs.
262-
*/
263-
public Map<Long, Long> getPressedState() {
264-
KeyEmbedderResponder embedderResponder = (KeyEmbedderResponder) responders[0];
265-
return embedderResponder.getPressedState();
266-
}
267255
}

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import io.flutter.embedding.engine.renderer.RenderSurface;
2727
import io.flutter.embedding.engine.systemchannels.AccessibilityChannel;
2828
import io.flutter.embedding.engine.systemchannels.DeferredComponentChannel;
29-
import io.flutter.embedding.engine.systemchannels.KeyboardChannel;
3029
import io.flutter.embedding.engine.systemchannels.LifecycleChannel;
3130
import io.flutter.embedding.engine.systemchannels.LocalizationChannel;
3231
import io.flutter.embedding.engine.systemchannels.MouseCursorChannel;
@@ -90,7 +89,6 @@ public class FlutterEngine implements ViewUtils.DisplayUpdater {
9089
// System channels.
9190
@NonNull private final AccessibilityChannel accessibilityChannel;
9291
@NonNull private final DeferredComponentChannel deferredComponentChannel;
93-
@NonNull private final KeyboardChannel keyboardChannel;
9492
@NonNull private final LifecycleChannel lifecycleChannel;
9593
@NonNull private final LocalizationChannel localizationChannel;
9694
@NonNull private final MouseCursorChannel mouseCursorChannel;
@@ -326,7 +324,6 @@ public FlutterEngine(
326324

327325
accessibilityChannel = new AccessibilityChannel(dartExecutor, flutterJNI);
328326
deferredComponentChannel = new DeferredComponentChannel(dartExecutor);
329-
keyboardChannel = new KeyboardChannel(dartExecutor);
330327
lifecycleChannel = new LifecycleChannel(dartExecutor);
331328
localizationChannel = new LocalizationChannel(dartExecutor);
332329
mouseCursorChannel = new MouseCursorChannel(dartExecutor);
@@ -519,12 +516,6 @@ public AccessibilityChannel getAccessibilityChannel() {
519516
return accessibilityChannel;
520517
}
521518

522-
/** System channel that allows querying the keyboard pressed state. */
523-
@NonNull
524-
public KeyboardChannel getKeyboardChannel() {
525-
return keyboardChannel;
526-
}
527-
528519
/** System channel that sends Android lifecycle events to Flutter. */
529520
@NonNull
530521
public LifecycleChannel getLifecycleChannel() {

shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyboardChannel.java

Lines changed: 0 additions & 73 deletions
This file was deleted.

shell/platform/android/io/flutter/plugin/keyboard/KeyboardPlugin.java

Lines changed: 0 additions & 57 deletions
This file was deleted.

shell/platform/android/io/flutter/view/FlutterView.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import io.flutter.embedding.engine.renderer.FlutterRenderer;
4949
import io.flutter.embedding.engine.renderer.SurfaceTextureWrapper;
5050
import io.flutter.embedding.engine.systemchannels.AccessibilityChannel;
51-
import io.flutter.embedding.engine.systemchannels.KeyboardChannel;
5251
import io.flutter.embedding.engine.systemchannels.LifecycleChannel;
5352
import io.flutter.embedding.engine.systemchannels.LocalizationChannel;
5453
import io.flutter.embedding.engine.systemchannels.MouseCursorChannel;
@@ -60,7 +59,6 @@
6059
import io.flutter.plugin.common.ActivityLifecycleListener;
6160
import io.flutter.plugin.common.BinaryMessenger;
6261
import io.flutter.plugin.editing.TextInputPlugin;
63-
import io.flutter.plugin.keyboard.KeyboardPlugin;
6462
import io.flutter.plugin.localization.LocalizationPlugin;
6563
import io.flutter.plugin.mouse.MouseCursorPlugin;
6664
import io.flutter.plugin.platform.PlatformPlugin;
@@ -126,14 +124,12 @@ static final class ViewportMetrics {
126124
private final FlutterRenderer flutterRenderer;
127125
private final NavigationChannel navigationChannel;
128126
private final LifecycleChannel lifecycleChannel;
129-
private final KeyboardChannel keyboardChannel;
130127
private final LocalizationChannel localizationChannel;
131128
private final PlatformChannel platformChannel;
132129
private final SettingsChannel settingsChannel;
133130
private final SystemChannel systemChannel;
134131
private final InputMethodManager mImm;
135132
private final TextInputPlugin mTextInputPlugin;
136-
private final KeyboardPlugin mKeyboardPlugin;
137133
private final LocalizationPlugin mLocalizationPlugin;
138134
private final MouseCursorPlugin mMouseCursorPlugin;
139135
private final KeyboardManager mKeyboardManager;
@@ -217,7 +213,6 @@ public void surfaceDestroyed(SurfaceHolder holder) {
217213

218214
// Create all platform channels
219215
navigationChannel = new NavigationChannel(dartExecutor);
220-
keyboardChannel = new KeyboardChannel(dartExecutor);
221216
lifecycleChannel = new LifecycleChannel(dartExecutor);
222217
localizationChannel = new LocalizationChannel(dartExecutor);
223218
platformChannel = new PlatformChannel(dartExecutor);
@@ -238,9 +233,7 @@ public void onPostResume() {
238233
mNativeView.getPluginRegistry().getPlatformViewsController();
239234
mTextInputPlugin =
240235
new TextInputPlugin(this, new TextInputChannel(dartExecutor), platformViewsController);
241-
242236
mKeyboardManager = new KeyboardManager(this);
243-
mKeyboardPlugin = new KeyboardPlugin(mKeyboardManager, keyboardChannel);
244237

245238
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
246239
mMouseCursorPlugin = new MouseCursorPlugin(this, new MouseCursorChannel(dartExecutor));

shell/platform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import io.flutter.embedding.engine.renderer.FlutterRenderer;
4040
import io.flutter.embedding.engine.renderer.FlutterUiDisplayListener;
4141
import io.flutter.embedding.engine.systemchannels.AccessibilityChannel;
42-
import io.flutter.embedding.engine.systemchannels.KeyboardChannel;
4342
import io.flutter.embedding.engine.systemchannels.LifecycleChannel;
4443
import io.flutter.embedding.engine.systemchannels.LocalizationChannel;
4544
import io.flutter.embedding.engine.systemchannels.MouseCursorChannel;
@@ -1294,7 +1293,6 @@ private FlutterEngine mockFlutterEngine() {
12941293
when(engine.getAccessibilityChannel()).thenReturn(mock(AccessibilityChannel.class));
12951294
when(engine.getActivityControlSurface()).thenReturn(mock(ActivityControlSurface.class));
12961295
when(engine.getDartExecutor()).thenReturn(mock(DartExecutor.class));
1297-
when(engine.getKeyboardChannel()).thenReturn(mock(KeyboardChannel.class));
12981296
when(engine.getLifecycleChannel()).thenReturn(mock(LifecycleChannel.class));
12991297
when(engine.getLocalizationChannel()).thenReturn(mock(LocalizationChannel.class));
13001298
when(engine.getLocalizationPlugin()).thenReturn(mock(LocalizationPlugin.class));

0 commit comments

Comments
 (0)