Disable FlutterMetalLayer by default. (#54095)

Jonah Williams · web-flow · commit f4f0bf3fe811 · 2024-07-25T02:34:16.000Z
Backing textures aren't getting deallocated, which is causing memory leaks and crashing devicelab.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterMetalLayer.mm b/shell/platform/darwin/ios/framework/Source/FlutterMetalLayer.mm
@@ -424,14 +424,14 @@ - (void)returnTexture:(FlutterTexture*)texture {
 }
 
 + (BOOL)enabled {
-  static BOOL enabled = YES;
+  static BOOL enabled = NO;
   static BOOL didCheckInfoPlist = NO;
   if (!didCheckInfoPlist) {
     didCheckInfoPlist = YES;
     NSNumber* use_flutter_metal_layer =
         [[NSBundle mainBundle] objectForInfoDictionaryKey:@"FLTUseFlutterMetalLayer"];
-    if (use_flutter_metal_layer != nil && ![use_flutter_metal_layer boolValue]) {
-      enabled = NO;
+    if (use_flutter_metal_layer != nil && [use_flutter_metal_layer boolValue]) {
+      enabled = YES;
     }
   }
   return enabled;

Original file line number	Diff line number	Diff line change
`@@ -424,14 +424,14 @@ - (void)returnTexture:(FlutterTexture*)texture {`
`424`	`424`	`}`
`425`	`425`
`426`	`426`	`+ (BOOL)enabled {`
`427`		`- static BOOL enabled = YES;`
	`427`	`+ static BOOL enabled = NO;`
`428`	`428`	`static BOOL didCheckInfoPlist = NO;`
`429`	`429`	`if (!didCheckInfoPlist) {`
`430`	`430`	`didCheckInfoPlist = YES;`
`431`	`431`	`NSNumber* use_flutter_metal_layer =`
`432`	`432`	`[[NSBundle mainBundle] objectForInfoDictionaryKey:@"FLTUseFlutterMetalLayer"];`
`433`		`- if (use_flutter_metal_layer != nil && ![use_flutter_metal_layer boolValue]) {`
`434`		`- enabled = NO;`
	`433`	`+ if (use_flutter_metal_layer != nil && [use_flutter_metal_layer boolValue]) {`
	`434`	`+ enabled = YES;`
`435`	`435`	`}`
`436`	`436`	`}`
`437`	`437`	`return enabled;`