Feedback

Author: Emmanuel Garcia

shell/common/rasterizer.cc

@@ -424,8 +424,6 @@ RasterStatus Rasterizer::DrawToSurface(flutter::LayerTree& layer_tree) {
       FML_DCHECK(!frame->IsSubmitted());
       external_view_embedder->SubmitFrame(surface_->GetContext(),
                                           std::move(frame));
-      // The frame must be submitted at this point.
-      FML_DCHECK(frame->IsSubmitted());
     } else {
       frame->Submit();
     }

shell/common/surface_frame.cc

@@ -11,8 +11,7 @@ namespace flutter {
 SurfaceFrame::SurfaceFrame(sk_sp<SkSurface> surface,
                            bool supports_readback,
                            const SubmitCallback& submit_callback)
-    : submitted_(false),
-      surface_(surface),
+    : surface_(surface),
       supports_readback_(supports_readback),
       submit_callback_(submit_callback) {
   FML_DCHECK(submit_callback_);

shell/common/surface_frame.h

@@ -37,7 +37,7 @@ class SurfaceFrame {
   bool supports_readback() { return supports_readback_; }
 
  private:
-  bool submitted_;
+  bool submitted_ = false;
   sk_sp<SkSurface> surface_;
   bool supports_readback_;
   SubmitCallback submit_callback_;