Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f1c98a5

Browse files
author
Dart CI
committed
Version 2.17.0-10.0.dev
Merge commit '442836bce4676cd4ed1b8518af2e1a2dc5c1a463' into 'dev'
2 parents d2c0ae6 + 442836b commit f1c98a5

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ vars = {
4444
# co19 is a cipd package. Use update.sh in tests/co19[_2] to update these
4545
# hashes. It requires access to the dart-build-access group, which EngProd
4646
# has.
47-
"co19_rev": "a4144628905e0d3326b2549c9a1425bfca06c681",
47+
"co19_rev": "143ad7f74919b132951e447a547236e991d9f900",
4848
# This line prevents conflicts when both packages are rolled simultaneously.
4949
"co19_2_rev": "995745937abffe9fc3a6441f9f0db27b2d706e4c",
5050

pkg/front_end/test/fasta/types/shared_type_tests.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,10 @@ abstract class SubtypeTest<T, E> {
426426
typeParameters: 'T extends Object');
427427
isObliviousSubtype('T & Future<int?>', 'FutureOr<num>?',
428428
typeParameters: 'T extends Object');
429+
isNotSubtype('FutureOr<T?>?', 'FutureOr<Never?>?',
430+
typeParameters: 'T extends FutureOr<T?>?');
431+
isSubtype('FutureOr<Never?>?', 'FutureOr<T?>?',
432+
typeParameters: 'T extends FutureOr<T?>?');
429433

430434
if (!skipFutureOrPromotion) {
431435
isSubtype('T & FutureOr<int*>*', 'FutureOr<num*>*', typeParameters: 'T');

pkg/kernel/lib/src/types.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,12 +404,11 @@ class IsInterfaceSubtypeOf extends TypeRelation<InterfaceType> {
404404
IsSubtypeOf isFutureOrRelated(FutureOrType s, InterfaceType t, Types types) {
405405
// Rules 7.1 and 7.2.
406406
return types
407-
.performNullabilityAwareSubtypeCheck(s.typeArgument, t)
408-
.andSubtypeCheckFor(
407+
.performNullabilityAwareSubtypeCheck(
409408
new InterfaceType(types.hierarchy.coreTypes.futureClass,
410409
Nullability.nonNullable, [s.typeArgument]),
411-
t,
412-
types)
410+
t)
411+
.andSubtypeCheckFor(s.typeArgument, t, types)
413412
.and(new IsSubtypeOf.basedSolelyOnNullabilities(s, t));
414413
}
415414

tools/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ CHANNEL dev
2727
MAJOR 2
2828
MINOR 17
2929
PATCH 0
30-
PRERELEASE 9
30+
PRERELEASE 10
3131
PRERELEASE_PATCH 0

tools/yaml2json.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ main(List<String> rawArguments) {
2828
stderr.writeln("Usage: yaml2json.dart input.yaml output.json [--check]");
2929
exit(1);
3030
}
31-
Uri input = Uri.base.resolve(arguments[0]);
32-
Uri output = Uri.base.resolve(arguments[1]);
31+
Uri input = new File(arguments[0]).absolute.uri;
32+
Uri output = new File(arguments[1]).absolute.uri;
3333
String inputString = arguments[0];
3434
String outputString = arguments[1];
3535
if (relative != null) {
36-
String relativeTo = Uri.base.resolve(relative).toString();
36+
String relativeTo = new File(relative).absolute.uri.toString();
3737
if (input.toString().startsWith(relativeTo)) {
3838
inputString = input.toString().substring(relativeTo.length);
3939
}

0 commit comments

Comments
 (0)