Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ed40c59

Browse files
authored
Started using a specific python for yapf (#55905)
fixes flutter/flutter#156993 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 7d1abd9 commit ed40c59

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

tools/yapf.sh

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,19 @@ function follow_links() (
3636
SCRIPT_DIR=$(follow_links "$(dirname -- "${BASH_SOURCE[0]}")")
3737
SRC_DIR="$(cd "$SCRIPT_DIR/../.."; pwd -P)"
3838
YAPF_DIR="$(cd "$SRC_DIR/flutter/third_party/yapf"; pwd -P)"
39+
if command -v python3.10 &> /dev/null; then
40+
PYTHON_EXEC="python3.10"
41+
else
42+
python3 -c "
43+
import sys
44+
version = sys.version_info
45+
if (version.major, version.minor) > (3, 10):
46+
print(f'Error: python3 version {version.major}.{version.minor} is greater than 3.10.', file=sys.stderr)
47+
sys.exit(1)
48+
else:
49+
print(f'Using python3 version {version.major}.{version.minor}.')
50+
" || exit 1
51+
PYTHON_EXEC="python3"
52+
fi
3953

40-
PYTHONPATH="$YAPF_DIR" python3 "$YAPF_DIR/yapf" "$@"
54+
PYTHONPATH="$YAPF_DIR" $PYTHON_EXEC "$YAPF_DIR/yapf" "$@"

0 commit comments

Comments
 (0)