Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e98ade9

Browse files
resolve symbols
1 parent fbf7eeb commit e98ade9

File tree

3 files changed

+22
-25
lines changed

3 files changed

+22
-25
lines changed

shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,9 @@ public void attachToFlutterEngine(@NonNull FlutterEngine flutterEngine) {
980980
new KeyboardManager(
981981
this,
982982
textInputPlugin,
983-
new Responder[] {new KeyChannelResponder(flutterEngine.getKeyEventChannel())});
983+
new KeyChannelResponder[] {
984+
new KeyChannelResponder(flutterEngine.getKeyEventChannel())
985+
});
984986
androidTouchProcessor =
985987
new AndroidTouchProcessor(this.flutterEngine.getRenderer(), /*trackMotionEvents=*/ false);
986988
accessibilityBridge =

shell/platform/android/io/flutter/view/FlutterView.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,9 @@ public void onPostResume() {
231231
new TextInputPlugin(this, new TextInputChannel(dartExecutor), platformViewsController);
232232
mKeyboardManager =
233233
new KeyboardManager(
234-
this, mTextInputPlugin, new Responder[] {new KeyChannelResponder(keyEventChannel)});
234+
this,
235+
mTextInputPlugin,
236+
new KeyChannelResponder[] {new KeyChannelResponder(keyEventChannel)});
235237

236238
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
237239
mMouseCursorPlugin = new MouseCursorPlugin(this, new MouseCursorChannel(dartExecutor));

shell/platform/android/test/io/flutter/embedding/android/KeyboardManagerTest.java

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import android.view.KeyEvent;
1515
import android.view.View;
1616
import androidx.annotation.NonNull;
17-
import io.flutter.embedding.android.KeyboardManager.PrimaryResponder;
17+
import io.flutter.embedding.android.KeyboardManager.Responder;
1818
import io.flutter.embedding.engine.FlutterEngine;
1919
import io.flutter.embedding.engine.FlutterJNI;
2020
import io.flutter.embedding.engine.systemchannels.KeyEventChannel;
@@ -33,7 +33,7 @@
3333
@RunWith(RobolectricTestRunner.class)
3434
@TargetApi(28)
3535
public class KeyboardManagerTest {
36-
static class FakeResponder implements PrimaryResponder {
36+
static class FakeResponder implements Responder {
3737
KeyEvent mLastKeyEvent;
3838
OnKeyEventHandledCallback mLastKeyEventHandledCallback;
3939

@@ -84,7 +84,7 @@ public void setUp() {
8484
new KeyboardManager(
8585
mockView,
8686
mockTextInputPlugin,
87-
new Responder[] {new KeyChannelResponder(flutterEngine.getKeyEventChannel())});
87+
new Responder[] {new KeyChannelResponder(mockKeyEventChannel)});
8888
}
8989

9090
// Tests start
@@ -94,7 +94,7 @@ public void respondsTrueWhenHandlingNewEvents() {
9494
final FakeResponder fakeResponder = new FakeResponder();
9595
keyboardManager =
9696
new KeyboardManager(
97-
mockView, mockTextInputPlugin, new KeyboardManager.PrimaryResponder[] {fakeResponder});
97+
mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {fakeResponder});
9898
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
9999
final boolean result = keyboardManager.handleEvent(keyEvent);
100100

@@ -111,7 +111,7 @@ public void primaryRespondersHaveTheHighestPrecedence() {
111111
final FakeResponder fakeResponder = new FakeResponder();
112112
keyboardManager =
113113
new KeyboardManager(
114-
mockView, mockTextInputPlugin, new KeyboardManager.PrimaryResponder[] {fakeResponder});
114+
mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {fakeResponder});
115115
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
116116
final boolean result = keyboardManager.handleEvent(keyEvent);
117117

@@ -131,10 +131,9 @@ public void primaryRespondersHaveTheHighestPrecedence() {
131131
}
132132

133133
@Test
134-
public void zeroPrimaryRespondersTest() {
134+
public void zeroRespondersTest() {
135135
keyboardManager =
136-
new KeyboardManager(
137-
mockView, mockTextInputPlugin, new KeyboardManager.PrimaryResponder[] {});
136+
new KeyboardManager(mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {});
138137
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
139138
final boolean result = keyboardManager.handleEvent(keyEvent);
140139
assertEquals(true, result);
@@ -144,14 +143,14 @@ public void zeroPrimaryRespondersTest() {
144143
}
145144

146145
@Test
147-
public void multiplePrimaryRespondersTest() {
146+
public void multipleRespondersTest() {
148147
final FakeResponder fakeResponder1 = new FakeResponder();
149148
final FakeResponder fakeResponder2 = new FakeResponder();
150149
keyboardManager =
151150
new KeyboardManager(
152151
mockView,
153152
mockTextInputPlugin,
154-
new KeyboardManager.PrimaryResponder[] {fakeResponder1, fakeResponder2});
153+
new KeyboardManager.Responder[] {fakeResponder1, fakeResponder2});
155154
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
156155
final boolean result = keyboardManager.handleEvent(keyEvent);
157156

@@ -169,14 +168,14 @@ public void multiplePrimaryRespondersTest() {
169168
}
170169

171170
@Test
172-
public void multiplePrimaryRespondersTest2() {
171+
public void multipleRespondersTest2() {
173172
final FakeResponder fakeResponder1 = new FakeResponder();
174173
final FakeResponder fakeResponder2 = new FakeResponder();
175174
keyboardManager =
176175
new KeyboardManager(
177176
mockView,
178177
mockTextInputPlugin,
179-
new KeyboardManager.PrimaryResponder[] {fakeResponder1, fakeResponder2});
178+
new KeyboardManager.Responder[] {fakeResponder1, fakeResponder2});
180179
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
181180
final boolean result = keyboardManager.handleEvent(keyEvent);
182181

@@ -188,14 +187,14 @@ public void multiplePrimaryRespondersTest2() {
188187
}
189188

190189
@Test
191-
public void multiplePrimaryRespondersTest3() {
190+
public void multipleRespondersTest3() {
192191
final FakeResponder fakeResponder1 = new FakeResponder();
193192
final FakeResponder fakeResponder2 = new FakeResponder();
194193
keyboardManager =
195194
new KeyboardManager(
196195
mockView,
197196
mockTextInputPlugin,
198-
new KeyboardManager.PrimaryResponder[] {fakeResponder1, fakeResponder2});
197+
new KeyboardManager.Responder[] {fakeResponder1, fakeResponder2});
199198
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
200199
final boolean result = keyboardManager.handleEvent(keyEvent);
201200

@@ -217,9 +216,7 @@ public void textInputPluginHasTheSecondHighestPrecedence() {
217216
keyboardManager =
218217
spy(
219218
new KeyboardManager(
220-
mockView,
221-
mockTextInputPlugin,
222-
new KeyboardManager.PrimaryResponder[] {fakeResponder}));
219+
mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {fakeResponder}));
223220
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
224221
final boolean result = keyboardManager.handleEvent(keyEvent);
225222

@@ -251,9 +248,7 @@ public void RedispatchKeyEventIfTextInputPluginFailsToHandle() {
251248
keyboardManager =
252249
spy(
253250
new KeyboardManager(
254-
mockView,
255-
mockTextInputPlugin,
256-
new KeyboardManager.PrimaryResponder[] {fakeResponder}));
251+
mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {fakeResponder}));
257252
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
258253
final boolean result = keyboardManager.handleEvent(keyEvent);
259254

@@ -280,9 +275,7 @@ public void respondsFalseWhenHandlingRedispatchedEvents() {
280275
keyboardManager =
281276
spy(
282277
new KeyboardManager(
283-
mockView,
284-
mockTextInputPlugin,
285-
new KeyboardManager.PrimaryResponder[] {fakeResponder}));
278+
mockView, mockTextInputPlugin, new KeyboardManager.Responder[] {fakeResponder}));
286279
final KeyEvent keyEvent = new FakeKeyEvent(KeyEvent.ACTION_DOWN, 65);
287280
final boolean result = keyboardManager.handleEvent(keyEvent);
288281

0 commit comments

Comments
 (0)