Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e67a30e

Browse files
authored
[web] @js('Intl') (#39211)
* [web] @js('Intl') * Fix call sites * one more place
1 parent daa8eeb commit e67a30e

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/web_ui/lib/src/engine/dom.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ extension DomWindowExtension on DomWindow {
6363
/// The Trusted Types API (when available).
6464
/// See: https://developer.mozilla.org/en-US/docs/Web/API/Trusted_Types_API
6565
external DomTrustedTypePolicyFactory? get trustedTypes;
66-
67-
// ignore: non_constant_identifier_names
68-
external DomIntl get Intl;
6966
}
7067

7168
typedef DomRequestAnimationFrameCallback = void Function(num highResTime);
@@ -83,6 +80,9 @@ extension DomConsoleExtension on DomConsole {
8380
@JS('window')
8481
external DomWindow get domWindow;
8582

83+
@JS('Intl')
84+
external DomIntl get domIntl;
85+
8686
@JS()
8787
@staticInterop
8888
class DomNavigator {}
@@ -1815,7 +1815,7 @@ extension DomV8BreakIteratorExtension on DomV8BreakIterator {
18151815
}
18161816

18171817
DomV8BreakIterator createV8BreakIterator() {
1818-
final Object? v8BreakIterator = domWindow.Intl.v8BreakIterator;
1818+
final Object? v8BreakIterator = domIntl.v8BreakIterator;
18191819
if (v8BreakIterator == null) {
18201820
throw UnimplementedError('v8BreakIterator is not supported.');
18211821
}

lib/web_ui/lib/src/engine/text/line_breaker.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ enum LineBreakType {
4242
/// Splits [text] into fragments based on line breaks.
4343
abstract class LineBreakFragmenter extends TextFragmenter {
4444
factory LineBreakFragmenter(String text) {
45-
if (domWindow.Intl.v8BreakIterator != null) {
45+
if (domIntl.v8BreakIterator != null) {
4646
return V8LineBreakFragmenter(text);
4747
}
4848
return FWLineBreakFragmenter(text);
@@ -66,7 +66,7 @@ class FWLineBreakFragmenter extends TextFragmenter implements LineBreakFragmente
6666
/// `v8BreakIterator` API to find line breaks in the given [text].
6767
class V8LineBreakFragmenter extends TextFragmenter implements LineBreakFragmenter {
6868
V8LineBreakFragmenter(super.text)
69-
: assert(domWindow.Intl.v8BreakIterator != null);
69+
: assert(domIntl.v8BreakIterator != null);
7070

7171
@override
7272
List<LineBreakFragment> fragment() {

lib/web_ui/test/text/line_breaker_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ void groupForEachFragmenter(GroupBody callback) {
421421
() => callback(isV8: false),
422422
);
423423

424-
if (domWindow.Intl.v8BreakIterator != null) {
424+
if (domIntl.v8BreakIterator != null) {
425425
group(
426426
'$V8LineBreakFragmenter',
427427
() => callback(isV8: true),

0 commit comments

Comments
 (0)