de-null vector_math.dart

Author: yjbanov

lib/web_ui/lib/src/engine/bitmap_canvas.dart

@@ -431,7 +431,7 @@ class BitmapCanvas extends EngineCanvas {
       }
     } else {
       final String cssTransform = float64ListToCssTransform(
-          transformWithOffset(_canvasPool.currentTransform, p).storage!);
+          transformWithOffset(_canvasPool.currentTransform, p).storage);
       imgElement.style
         ..transformOrigin = '0 0 0'
         ..transform = cssTransform
@@ -728,7 +728,7 @@ class BitmapCanvas extends EngineCanvas {
     } else {
       setElementTransform(
         paragraphElement,
-        transformWithOffset(_canvasPool.currentTransform, offset).storage!,
+        transformWithOffset(_canvasPool.currentTransform, offset).storage,
       );
       rootElement.append(paragraphElement);
     }
@@ -948,7 +948,7 @@ List<html.Element?> _clipContent(List<_SaveClipEntry> clipStack,
         ..overflow = 'hidden'
         ..width = '${rect.right - clipOffsetX}px'
         ..height = '${rect.bottom - clipOffsetY}px';
-      setElementTransform(curElement, newClipTransform.storage!);
+      setElementTransform(curElement, newClipTransform.storage);
     } else if (entry.rrect != null) {
       final ui.RRect roundRect = entry.rrect!;
       final String borderRadius =
@@ -963,7 +963,7 @@ List<html.Element?> _clipContent(List<_SaveClipEntry> clipStack,
         ..overflow = 'hidden'
         ..width = '${roundRect.right - clipOffsetX}px'
         ..height = '${roundRect.bottom - clipOffsetY}px';
-      setElementTransform(curElement, newClipTransform.storage!);
+      setElementTransform(curElement, newClipTransform.storage);
     } else if (entry.path != null) {
       curElement.style.transform = matrix4ToCssTransform(newClipTransform);
       String svgClipPath = createSvgClipDef(curElement as html.HtmlElement, entry.path!);
@@ -979,7 +979,7 @@ List<html.Element?> _clipContent(List<_SaveClipEntry> clipStack,
     reverseTransformDiv.style.position = 'absolute';
     setElementTransform(
       reverseTransformDiv,
-      (newClipTransform.clone()..invert()).storage!,
+      (newClipTransform.clone()..invert()).storage,
     );
     curElement.append(reverseTransformDiv);
     curElement = reverseTransformDiv;
@@ -989,7 +989,7 @@ List<html.Element?> _clipContent(List<_SaveClipEntry> clipStack,
   domRenderer.append(curElement!, content);
   setElementTransform(
     content,
-    transformWithOffset(currentTransform, offset).storage!,
+    transformWithOffset(currentTransform, offset).storage,
   );
   return <html.Element?>[root]..addAll(clipDefs);
 }

lib/web_ui/lib/src/engine/canvas_pool.dart

@@ -988,7 +988,7 @@ class _SaveStackTracking {
   @mustCallSuper
   void skew(double sx, double sy) {
     final Matrix4 skewMatrix = Matrix4.identity();
-    final Float32List storage = skewMatrix.storage!;
+    final Float32List storage = skewMatrix.storage;
     storage[1] = sy;
     storage[4] = sx;
     _currentTransform.multiply(skewMatrix);

lib/web_ui/lib/src/engine/compositor/embedded_views.dart

@@ -237,7 +237,7 @@ class HtmlViewEmbedder {
         case MutatorType.transform:
           headTransform.multiply(mutator.matrix!);
           head.style.transform =
-              float64ListToCssTransform(headTransform.storage!);
+              float64ListToCssTransform(headTransform.storage);
           break;
         case MutatorType.clipRect:
         case MutatorType.clipRRect:
@@ -295,7 +295,7 @@ class HtmlViewEmbedder {
     final Matrix4 scaleMatrix =
         Matrix4.diagonal3Values(inverseScale, inverseScale, 1);
     headTransform.multiply(scaleMatrix);
-    head.style.transform = float64ListToCssTransform(headTransform.storage!);
+    head.style.transform = float64ListToCssTransform(headTransform.storage);
   }
 
   /// Sets the transform origin to the top-left corner of the element.

lib/web_ui/lib/src/engine/engine_canvas.dart

@@ -204,7 +204,7 @@ mixin SaveStackTracking on EngineCanvas {
   @override
   void skew(double sx, double sy) {
     final Matrix4 skewMatrix = Matrix4.identity();
-    final Float32List storage = skewMatrix.storage!;
+    final Float32List storage = skewMatrix.storage;
     storage[1] = sy;
     storage[4] = sx;
     _currentTransform.multiply(skewMatrix);
@@ -267,7 +267,7 @@ html.Element _drawParagraphElement(
   if (transform != null) {
     setElementTransform(
       paragraphElement,
-      transformWithOffset(transform, offset).storage!,
+      transformWithOffset(transform, offset).storage,
     );
   }
 

lib/web_ui/lib/src/engine/houdini_canvas.dart

@@ -353,7 +353,7 @@ mixin SaveElementStackTracking on EngineCanvas {
     // DO NOT USE Matrix4.skew(sx, sy)! It treats sx and sy values as radians,
     // but in our case they are transform matrix values.
     final Matrix4 skewMatrix = Matrix4.identity();
-    final Float32List storage = skewMatrix.storage!;
+    final Float32List storage = skewMatrix.storage;
     storage[1] = sy;
     storage[4] = sx;
     _currentTransform.multiply(skewMatrix);

lib/web_ui/lib/src/engine/semantics/semantics.dart

@@ -827,8 +827,9 @@ class SemanticsObject {
         hasChildren ? getOrCreateChildContainer() : null;
 
     final bool hasZeroRectOffset = _rect!.top == 0.0 && _rect!.left == 0.0;
+    final Float32List? transform = _transform;
     final bool hasIdentityTransform =
-        _transform == null || isIdentityFloat32ListTransform(_transform!);
+        transform == null || isIdentityFloat32ListTransform(transform);
 
     if (hasZeroRectOffset &&
         hasIdentityTransform &&
@@ -848,19 +849,19 @@ class SemanticsObject {
     late Matrix4 effectiveTransform;
     bool effectiveTransformIsIdentity = true;
     if (!hasZeroRectOffset) {
-      if (_transform == null) {
+      if (transform == null) {
         final double left = _rect!.left;
         final double top = _rect!.top;
         effectiveTransform = Matrix4.translationValues(left, top, 0.0);
         effectiveTransformIsIdentity = left == 0.0 && top == 0.0;
       } else {
         // Clone to avoid mutating _transform.
-        effectiveTransform = Matrix4.fromFloat32List(_transform).clone()
+        effectiveTransform = Matrix4.fromFloat32List(transform).clone()
           ..translate(_rect!.left, _rect!.top, 0.0);
         effectiveTransformIsIdentity = effectiveTransform.isIdentity();
       }
     } else if (!hasIdentityTransform) {
-      effectiveTransform = Matrix4.fromFloat32List(_transform);
+      effectiveTransform = Matrix4.fromFloat32List(transform!);
       effectiveTransformIsIdentity = false;
     }
 

lib/web_ui/lib/src/engine/surface/path.dart

@@ -520,7 +520,7 @@ class SurfacePath implements ui.Path {
       subpaths.addAll(path.subpaths);
     } else {
       subpaths.addAll(path
-          ._transform(Matrix4.translationValues(dx, dy, 0.0).storage!)
+          ._transform(Matrix4.translationValues(dx, dy, 0.0).storage)
           .subpaths);
     }
   }
@@ -530,7 +530,7 @@ class SurfacePath implements ui.Path {
     assert(matrix4IsValid(matrix));
     final Matrix4 transform = Matrix4.fromFloat32List(matrix);
     transform.translate(dx, dy);
-    subpaths.addAll(path._transform(transform.storage!).subpaths);
+    subpaths.addAll(path._transform(transform.storage).subpaths);
   }
 
   /// Adds the given path to this path by extending the current segment of this

lib/web_ui/lib/src/engine/surface/recording_canvas.dart

@@ -1949,7 +1949,7 @@ class _PaintBounds {
     // DO NOT USE Matrix4.skew(sx, sy)! It treats sx and sy values as radians,
     // but in our case they are transform matrix values.
     final Matrix4 skewMatrix = Matrix4.identity();
-    final Float32List storage = skewMatrix.storage!;
+    final Float32List storage = skewMatrix.storage;
     storage[1] = sy;
     storage[4] = sx;
     _currentMatrix.multiply(skewMatrix);

lib/web_ui/lib/src/engine/surface/render_vertices.dart

@@ -262,7 +262,7 @@ ui.Rect _computeVerticesBounds(Float32List positions, Matrix4 transform) {
 
 ui.Rect _transformBounds(
     Matrix4 transform, double left, double top, double right, double bottom) {
-  final Float32List storage = transform.storage!;
+  final Float32List storage = transform.storage;
   final double m0 = storage[0];
   final double m1 = storage[1];
   final double m4 = storage[4];

lib/web_ui/lib/src/engine/surface/transform.dart

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-
 part of engine;
 
 /// A surface that transforms its children using CSS transform.
@@ -11,7 +10,7 @@ class PersistedTransform extends PersistedContainerSurface
   PersistedTransform(PersistedTransform? oldLayer, this.matrix4)
       : super(oldLayer);
 
-  final Float32List? matrix4;
+  final Float32List matrix4;
 
   @override
   void recomputeTransformAndClip() {
@@ -35,7 +34,7 @@ class PersistedTransform extends PersistedContainerSurface
 
   @override
   void apply() {
-    rootElement!.style.transform = float64ListToCssTransform(matrix4!);
+    rootElement!.style.transform = float64ListToCssTransform(matrix4);
   }
 
   @override
@@ -47,8 +46,8 @@ class PersistedTransform extends PersistedContainerSurface
     }
 
     bool matrixChanged = false;
-    for (int i = 0; i < matrix4!.length; i++) {
-      if (matrix4![i] != oldSurface.matrix4![i]) {
+    for (int i = 0; i < matrix4.length; i++) {
+      if (matrix4[i] != oldSurface.matrix4[i]) {
         matrixChanged = true;
         break;
       }